Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
250b14de
Unverified
Commit
250b14de
authored
3 years ago
by
Noah Moss
Committed by
GitHub
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
test that LDAP works with $ in password (#16092)
parent
aad24de7
Loading
Loading
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
test/metabase/integrations/ldap_test.clj
+5
-1
5 additions, 1 deletion
test/metabase/integrations/ldap_test.clj
test_resources/ldap.ldif
+1
-1
1 addition, 1 deletion
test_resources/ldap.ldif
with
6 additions
and
2 deletions
test/metabase/integrations/ldap_test.clj
+
5
−
1
View file @
250b14de
...
...
@@ -64,7 +64,11 @@
(
testing
"fail regular user login with bad password"
(
is
(
=
false
(
ldap/verify-password
"cn=Sally Brown,ou=People,dc=metabase,dc=com"
"password"
))))))
(
ldap/verify-password
"cn=Sally Brown,ou=People,dc=metabase,dc=com"
"password"
))))
(
testing
"password containing dollar signs succeeds (#15145)"
(
is
(
=
true
(
ldap/verify-password
"cn=Fred Taylor,ou=People,dc=metabase,dc=com"
,
"pa$$word"
))))))
(
deftest
find-test
;; there are EE-specific versions of this test in `metabase-enterprise.enhancements.integrations.ldap-test`
...
...
This diff is collapsed.
Click to expand it.
test_resources/ldap.ldif
+
1
−
1
View file @
250b14de
...
...
@@ -44,7 +44,7 @@ sN: Taylor
givenname: Fred
uid: ftaylor300
mAiL: fred.taylor@metabase.com
userpassword:
unh4ck4bl3
userpassword:
pa$$word
dn: ou=Birds,dc=metabase,dc=com
objectClass: top
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment