default to just testing against generic-sql

circle.yml

@@ -4,5 +4,10 @@ machine:
       oraclejdk8
 test:
   override:
-    - case $CIRCLE_NODE_INDEX in 0) lein test ;; 1) MB_DB_TYPE=postgres MB_DB_DBNAME=circle_test MB_DB_PORT=5432 MB_DB_USER=ubuntu MB_DB_HOST=localhost lein test ;; 2) lein eastwood ;; 3) ./lint_js.sh && lein bikeshed --max-line-length 240 ;; 4) lein uberjar ;; esac:
+    # 0) runs unit tests w/ H2 local DB. Runs against both Mongo + H2 test datasets
+    # 1) runs unit tests w/ Postgres local DB. Only runs against H2 test dataset so we can be sure tests work in either scenario
+    # 2) runs Eastwood linter
+    # 3) runs JS linter + Bikeshed linter
+    # 4) Runs lein uberjar
+    - case $CIRCLE_NODE_INDEX in 0) MB_TEST_DATASETS=generic-sql,mongo lein test ;; 1) MB_DB_TYPE=postgres MB_DB_DBNAME=circle_test MB_DB_PORT=5432 MB_DB_USER=ubuntu MB_DB_HOST=localhost lein test ;; 2) lein eastwood ;; 3) ./lint_js.sh && lein bikeshed --max-line-length 240 ;; 4) lein uberjar ;; esac:
         parallel: true

test/metabase/test/data/datasets.clj

@@ -96,13 +96,13 @@
 
 ;; # Logic for determining which datasets to test against
 
-;; By default, we'll test against *all* datasets; otherwise, you can test against only a
-;; subset of them by setting the env var `MB_TEST_DATASETS` to a comma-separated list of driver names, e.g.
+;; By default, we'll test against against only the :generic-sql (H2) dataset; otherwise, you can specify which
+;; datasets to test against by setting the env var `MB_TEST_DATASETS` to a comma-separated list of dataset names, e.g.
 ;;
 ;;    # test against :generic-sql and :mongo
 ;;    MB_TEST_DATASETS=generic-sql,mongo
 ;;
-;;    # just test against :generic-sql
+;;    # just test against :generic-sql (default)
 ;;    MB_TEST_DATASETS=generic-sql
 
 (defn- get-test-datasets-from-env
@@ -121,9 +121,9 @@
 
 (def test-dataset-names
   "Delay that returns set of names of drivers we should run tests against.
-   By default, this returns *all* drivers, but can be overriden by setting env var `MB_TEST_DATASETS`."
+   By default, this returns only `:generic-sql`, but can be overriden by setting env var `MB_TEST_DATASETS`."
   (delay (let [datasets (or (get-test-datasets-from-env)
-                            all-valid-dataset-names)]
+                            #{:generic-sql})]
            (log/info (color/green "Running QP tests against these datasets: " datasets))
            datasets)))