-
- Downloads
Add ESLint rule for Metabase strings (#38553)
* Fix case where Metabase links are render inside template strings * Add `no-literal-metabase-strings` ESLint rule * Fix all Metabase string errors * Address review: Fix the rule The rule was checking if we have imported the selector `getApplicationName` then ignore all Metabase strings. This is different than `no-unconditional-metabase-links-render` because in that rule, when fixed the Documentation URLs are still in the file, but in this rule, when fixed, there should be no Metabase strings left in the file. * Fix errors from the new lint rule
Showing
- frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js 26 additions, 0 deletions...tests/no-unconditional-metabase-links-render.unit.spec.js
- frontend/src/metabase-lib/expressions/helper-text-strings.ts 1 addition, 0 deletionsfrontend/src/metabase-lib/expressions/helper-text-strings.ts
- frontend/src/metabase-types/api/mocks/settings.ts 1 addition, 0 deletionsfrontend/src/metabase-types/api/mocks/settings.ts
- frontend/src/metabase/databases/components/DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsx 1 addition, 0 deletions...DatabaseCacheScheduleField/DatabaseCacheScheduleField.tsx
- frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx 2 additions, 0 deletions...omponents/DatabaseEngineWarning/DatabaseEngineWarning.tsx
- frontend/src/metabase/databases/components/DatabaseNameField/DatabaseNameField.tsx 1 addition, 0 deletions...abases/components/DatabaseNameField/DatabaseNameField.tsx
- frontend/src/metabase/databases/components/DatabaseSyncModal/DatabaseSyncModal.tsx 2 additions, 1 deletion...abases/components/DatabaseSyncModal/DatabaseSyncModal.tsx
- frontend/src/metabase/home/components/EmbedMinimalHomepage/EmbedMinimalHomepage.tsx 1 addition, 0 deletions.../components/EmbedMinimalHomepage/EmbedMinimalHomepage.tsx
- frontend/src/metabase/lib/api.js 2 additions, 0 deletionsfrontend/src/metabase/lib/api.js
- frontend/src/metabase/lib/i18n.js 1 addition, 0 deletionsfrontend/src/metabase/lib/i18n.js
- frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx 1 addition, 0 deletions...d/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx
- frontend/src/metabase/nav/components/DatabasePromptBanner/DatabasePromptBanner.tsx 1 addition, 0 deletions.../components/DatabasePromptBanner/DatabasePromptBanner.tsx
- frontend/src/metabase/nav/components/ProfileLink/ProfileLink.jsx 2 additions, 0 deletions...d/src/metabase/nav/components/ProfileLink/ProfileLink.jsx
- frontend/src/metabase/nav/components/WhatsNewNotification/WhatsNewNotification.tsx 1 addition, 0 deletions.../components/WhatsNewNotification/WhatsNewNotification.tsx
- frontend/src/metabase/plugins/index.ts 1 addition, 0 deletionsfrontend/src/metabase/plugins/index.ts
- frontend/src/metabase/public/components/EmbedFrame/LogoBadge.tsx 1 addition, 0 deletions...d/src/metabase/public/components/EmbedFrame/LogoBadge.tsx
- frontend/src/metabase/public/components/EmbedModal/SelectEmbedTypePane/InteractiveEmbeddingCTA/InteractiveEmbeddingCTA.tsx 1 addition, 0 deletions...ePane/InteractiveEmbeddingCTA/InteractiveEmbeddingCTA.tsx
- frontend/src/metabase/public/components/EmbedModal/StaticEmbedSetupPane/AppearanceSettings.tsx 2 additions, 0 deletions...ts/EmbedModal/StaticEmbedSetupPane/AppearanceSettings.tsx
- frontend/src/metabase/public/components/widgets/LegaleseStep/LegaleseStep.tsx 1 addition, 0 deletions...e/public/components/widgets/LegaleseStep/LegaleseStep.tsx
- frontend/src/metabase/redux/settings.ts 1 addition, 0 deletionsfrontend/src/metabase/redux/settings.ts
Loading
Please register or sign in to comment