Skip to content
Snippets Groups Projects
Unverified Commit 279b3721 authored by Mahatthana (Kelvin) Nomsawadi's avatar Mahatthana (Kelvin) Nomsawadi Committed by GitHub
Browse files

Add ESLint rule for Metabase strings (#38553)

* Fix case where Metabase links are render inside template strings

* Add `no-literal-metabase-strings` ESLint rule

* Fix all Metabase string errors

* Address review: Fix the rule

The rule was checking if we have imported the selector
`getApplicationName` then ignore all Metabase strings. This is different
than `no-unconditional-metabase-links-render` because in that rule, when
fixed the Documentation URLs are still in the file, but in this rule,
when fixed, there should be no Metabase strings left in the file.

* Fix errors from the new lint rule
parent 985ef5d0
No related branches found
No related tags found
No related merge requests found
Showing
with 50 additions and 1 deletion
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment