Fix logic for deployment-model in stats ping (#49260)

src/metabase/analytics/stats.clj

@@ -516,10 +516,10 @@
 
 (defn- deployment-model
   []
-  (case
-   (premium-features/is-hosted?) "cloud"
-   (in-docker?) "docker"
-   :else "jar"))
+  (cond
+    (premium-features/is-hosted?) "cloud"
+    (in-docker?)                  "docker"
+    :else                         "jar"))
 
 (def ^:private activation-days 3)
 

test/metabase/analytics/stats_test.clj

 (ns metabase.analytics.stats-test
   (:require
+   [clojure.java.io :as io]
    [clojure.set :as set]
    [clojure.test :refer :all]
    [java-time.api :as t]
@@ -423,6 +424,23 @@
                     config/current-minor-version (constantly nil)]
         (is false? (@#'stats/csv-upload-available?))))))
 
+(deftest deployment-model-test
+  (testing "deployment model correctly reports cloud/docker/jar"
+    (with-redefs [premium-features/is-hosted? (constantly true)]
+      (is (= "cloud" (@#'stats/deployment-model))))
+
+    ;; Lets just mock io/file to always return an existing (temp) file, to validate that we're doing a filesystem check
+    ;; to determine whether we're in a Docker container
+    (mt/with-temp-file [mock-file]
+      (spit mock-file "Temp file!")
+      (with-redefs [premium-features/is-hosted? (constantly false)
+                    io/file                     (constantly (java.io.File. mock-file))]
+        (is (= "docker" (@#'stats/deployment-model)))))
+
+    (with-redefs [premium-features/is-hosted? (constantly false)
+                  stats/in-docker?            (constantly false)]
+      (is (= "jar" (@#'stats/deployment-model))))))
+
 (deftest no-features-enabled-but-not-available-test
   (testing "Ensure that a feature cannot be reported as enabled if it is not also available"
     ;; Clear premium features so (most of) the features are considered unavailable