Skip to content
Snippets Groups Projects
Unverified Commit 2a67d448 authored by Noah Moss's avatar Noah Moss Committed by GitHub
Browse files

Fix JS error on JWT settings form (#16394)

* fix default updateSettings function in SettingsBatchForm

* unskip repro
parent 6ff0cb79
Branches
Tags
No related merge requests found
......@@ -12,6 +12,8 @@ import DisclosureTriangle from "metabase/components/DisclosureTriangle";
import MetabaseUtils from "metabase/lib/utils";
import SettingsSetting from "./SettingsSetting";
import { updateSettings as defaultUpdateSettings } from "../settings";
const VALIDATIONS = {
email: {
validate: value => MetabaseUtils.validEmail(value),
......@@ -33,7 +35,7 @@ const SAVE_SETTINGS_BUTTONS_STATES = {
null,
(dispatch, { updateSettings }) => ({
updateSettings:
updateSettings || (settings => dispatch(updateSettings(settings))),
updateSettings || (settings => dispatch(defaultUpdateSettings(settings))),
}),
null,
{ withRef: true }, // HACK: needed so consuming components can call methods on the component :-/
......
......@@ -80,7 +80,7 @@ describe("scenarios > admin > settings > SSO", () => {
cy.visit("/admin/settings/authentication/jwt");
});
it.skip("should save JWT without an error (metabase#16378)", () => {
it("should save JWT without an error (metabase#16378)", () => {
cy.intercept("PUT", "/api/**").as("update");
cy.findByText("JWT Authentication")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment