Fix error in send-abandonment-emails task (#20976)

src/metabase/core.clj

@@ -39,6 +39,7 @@
         (str (deferred-trs "Metabase Enterprise Edition extensions are PRESENT.")
              "\n\n"
              (deferred-trs "Usage of Metabase Enterprise Edition features are subject to the Metabase Commercial License.")
+             " "
              (deferred-trs "See {0} for details." "https://www.metabase.com/license/commercial/"))
         (deferred-trs "Metabase Enterprise Edition extensions are NOT PRESENT."))))
 

src/metabase/task/follow_up_emails.clj

@@ -90,11 +90,17 @@
 
 (s/defn ^:private should-send-abandoment-email?
   ([]
-   (should-send-abandoment-email?
-    (instance-creation-timestamp)
-    (db/select-one [User [:%max.date_joined :last-user]])
-    (db/select-one [Activity [:%max.timestamp :last-activity]])
-    (db/select-one [ViewLog [:%max.timestamp :last-view]])))
+   (let [[last-user last-activity last-view]
+         (map :last (db/query
+                     {:union-all
+                      [{:select [[:%max.date_joined :last]], :from [User]}
+                       {:select [[:%max.timestamp :last]], :from [Activity]}
+                       {:select [[:%max.timestamp :last]], :from [ViewLog]}]}))]
+     (should-send-abandoment-email?
+      (instance-creation-timestamp)
+      last-user
+      last-activity
+      last-view)))
 
   ([instance-creation :- (s/maybe Temporal)
     last-user         :- (s/maybe Temporal)

test/metabase/task/follow_up_emails_test.clj

@@ -20,6 +20,9 @@
              (-> @inbox vals first count))))))
 
 (deftest should-send-abandoment-email-test
+  (testing "Make sure zero-arity version works (#12068)"
+    (testing `(follow-up-emails/should-send-abandoment-email?)
+      (is (boolean? (#'follow-up-emails/should-send-abandoment-email?)))))
   (testing "Conditions where abandonment emails should be sent"
     (doseq [now               [(t/zoned-date-time) (t/offset-date-time) (t/instant)]
             instance-creation [0 1 5 nil]