Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
2b4ca3aa
Unverified
Commit
2b4ca3aa
authored
8 years ago
by
Cam Saül
Browse files
Options
Downloads
Patches
Plain Diff
Remove field-type from Druid test code
parent
0920f1d1
No related branches found
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/metabase/driver/druid.clj
+6
-7
6 additions, 7 deletions
src/metabase/driver/druid.clj
test/metabase/test/data.clj
+1
-1
1 addition, 1 deletion
test/metabase/test/data.clj
test/metabase/test/data/interface.clj
+1
-1
1 addition, 1 deletion
test/metabase/test/data/interface.clj
with
8 additions
and
9 deletions
src/metabase/driver/druid.clj
+
6
−
7
View file @
2b4ca3aa
...
...
@@ -65,12 +65,12 @@
;;; ### Sync
(
defn-
describe-table-field
[
druid-field-type
field-name
]
(
merge
{
:name
field-name
}
;; all dimension
s are
S
tr
ings, and all metrics as JS Numbers, I think
(
?
)
;; string-encoded booleans + dates are treated as strings (!)
(
if
(
=
:metric
druid-field-type
)
{
:field-type
:metric,
:base-type
:FloatField
}
{
:field-type
:dimension,
:base-type
:TextField
})
))
;; all dimensions are Strings, and all metrics as JS Numbers, I think (?)
;; string-encoded booleans + date
s are tr
eated as strings
(
!
)
{
:name
field-name
:base-type
(
if
(
=
:metric
druid-field-type
)
:FloatField
:TextField
)
}
)
(
defn-
describe-table
[
database
table
]
(
let
[
details
(
:details
database
)
...
...
@@ -81,7 +81,6 @@
;; every Druid table is an event stream w/ a timestamp field
[{
:name
"timestamp"
:base-type
:DateTimeField
:field-type
:dimension
:pk?
true
}]
(
map
(
partial
describe-table-field
:dimension
)
dimensions
)
(
map
(
partial
describe-table-field
:metric
)
metrics
)))}))
...
...
This diff is collapsed.
Click to expand it.
test/metabase/test/data.clj
+
1
−
1
View file @
2b4ca3aa
...
...
@@ -188,7 +188,7 @@
;; Sync the database
(
sync-database/sync-database!
db
)
;; Add extra metadata like Field
field-type,
base-type, etc.
;; Add extra metadata like Field base-type, etc.
(
doseq
[
^
TableDefinition
table-definition
(
:table-definitions
database-definition
)]
(
let
[
table-name
(
:table-name
table-definition
)
table
(
delay
(
or
(
i/metabase-instance
table-definition
db
)
...
...
This diff is collapsed.
Click to expand it.
test/metabase/test/data/interface.clj
+
1
−
1
View file @
2b4ca3aa
...
...
@@ -131,7 +131,7 @@
(
defn
create-field-definition
"Create a new `FieldDefinition`; verify its values."
^
FieldDefinition
[
{
:keys
[
field-name
base-type
field-type
special-type
visibility-type
fk
]
,
:as
field-definition-map
}
]
^
FieldDefinition
[
field-definition-map
]
(
s/validate
FieldDefinition
(
map->FieldDefinition
field-definition-map
)))
(
defn
create-table-definition
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment