Move expression suggest files out of metabase-lib (#27207)

frontend/src/metabase/query_builder/components/expressions/ExpressionEditorHelpText.tsx

@@ -6,8 +6,8 @@ import MetabaseSettings from "metabase/lib/settings";
 import ExternalLink from "metabase/core/components/ExternalLink";
 import Icon from "metabase/components/Icon";
 import TippyPopover from "metabase/components/Popover/TippyPopover";
-import { getHelpDocsUrl } from "metabase-lib/expressions/helper-text-strings";
 import { HelpText } from "metabase-lib/expressions/types";
+import { getHelpDocsUrl } from "./ExpressionEditorTextfield/helper-text-strings";
 
 interface ExpressionEditorHelpTextProps {
   helpText: HelpText;

frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield.jsx → frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/ExpressionEditorTextfield.jsx

@@ -9,22 +9,21 @@ import AceEditor from "react-ace";
 import * as ace from "ace-builds/src-noconflict/ace";
 import ExplicitSize from "metabase/components/ExplicitSize";
 import { format } from "metabase-lib/expressions/format";
-import { suggest } from "metabase-lib/expressions/suggest";
 import { processSource } from "metabase-lib/expressions/process";
 import { diagnose } from "metabase-lib/expressions/diagnostics";
 import { tokenize } from "metabase-lib/expressions/tokenizer";
 
 import { isExpression } from "metabase-lib/expressions";
+import HelpText from "../ExpressionEditorHelpText";
+import ExpressionEditorSuggestions from "../ExpressionEditorSuggestions";
+import ExpressionMode from "../ExpressionMode";
+import { suggest } from "./suggest";
 
-import HelpText from "./ExpressionEditorHelpText";
-import ExpressionEditorSuggestions from "./ExpressionEditorSuggestions";
 import {
   EditorContainer,
   EditorEqualsSign,
 } from "./ExpressionEditorTextfield.styled";
 
-import ExpressionMode from "./ExpressionMode";
-
 ace.config.set("basePath", "/assets/ui/");
 
 const ErrorMessage = ({ error }) => {

frontend/src/metabase-lib/expressions/helper-text-strings.ts → frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/helper-text-strings.ts

 import { t } from "ttag";
-import { HelpText } from "./types";
+import { HelpText } from "metabase-lib/expressions/types";
 
 const helperTextStrings: HelpText[] = [
   {

frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/index.ts

+export { default } from "./ExpressionEditorTextfield";

frontend/src/metabase-lib/expressions/suggest.js → frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/suggest.js

 import _ from "underscore";
 
-import { getHelpText } from "metabase-lib/expressions/helper-text-strings";
-import { partialMatch, enclosingFunction } from "./completer";
+import {
+  partialMatch,
+  enclosingFunction,
+} from "metabase-lib/expressions/completer";
 import {
   EXPRESSION_FUNCTIONS,
   AGGREGATION_FUNCTIONS,
   MBQL_CLAUSES,
   getMBQLName,
   EDITOR_FK_SYMBOLS,
-} from "./config";
+} from "metabase-lib/expressions/config";
 import {
   getDimensionName,
   formatDimensionName,
   formatMetricName,
   formatSegmentName,
-} from "./index";
+} from "metabase-lib/expressions/index";
+import { getHelpText } from "./helper-text-strings";
 
 const suggestionText = func => {
   const { displayName, args } = func;

frontend/test/metabase/lib/expressions/suggest.unit.spec.js → frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/suggest.unit.spec.js

 import _ from "underscore";
 import { ORDERS, REVIEWS } from "__support__/sample_database_fixture";
-import { suggest as suggest_ } from "metabase-lib/expressions/suggest";
-
-import { aggregationOpts, expressionOpts } from "./__support__/expressions";
+import {
+  aggregationOpts,
+  expressionOpts,
+} from "../../../../../../test/metabase/lib/expressions/__support__/expressions";
+import { suggest as suggest_ } from "./suggest";
 
 // custom metadata defined in __support__/sample_database_fixture
 const SEGMENTS_ORDERS = [{ text: "[Expensive Things]", type: "segments" }];