Skip to content
Snippets Groups Projects
Commit 2bb5d97d authored by Tom Robinson's avatar Tom Robinson
Browse files

Don't enforce specific 'display' property on backend. Resolves #2205

parent 748b0c5b
No related branches found
No related tags found
No related merge requests found
......@@ -16,11 +16,6 @@
[symb value :nillable]
(checkp-contains? #{:all :mine :fav :database :table} symb (keyword value)))
(defannotation CardDisplayType
"Option must be a valid `display_type`."
[symb value :nillable]
(checkp-contains? card/display-types symb (keyword value)))
(defendpoint GET "/"
"Get all the `Cards`. With param `f` (default is `all`), restrict cards as follows:
......@@ -60,7 +55,7 @@
[:as {{:keys [dataset_query description display name public_perms visualization_settings]} :body}]
{name [Required NonEmptyString]
public_perms [Required PublicPerms]
display [Required CardDisplayType]}
display [Required NonEmptyString]}
(->> (ins Card
:creator_id *current-user-id*
:dataset_query dataset_query
......@@ -86,7 +81,7 @@
[id :as {{:keys [dataset_query description display name public_perms visualization_settings]} :body}]
{name NonEmptyString
public_perms PublicPerms
display CardDisplayType}
display NonEmptyString}
(write-check Card id)
(upd-non-nil-keys Card id
:dataset_query dataset_query
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment