Skip to content
Snippets Groups Projects
Unverified Commit 2d3b86d3 authored by Case Nelson's avatar Case Nelson Committed by GitHub
Browse files

[MLv2] Tests #12625 removing sorted aggregations (#35507)

Fixes #12625
parent cf59ad4f
Branches
Tags
No related merge requests found
......@@ -219,6 +219,22 @@
(lib/filter (lib/= [:field {:lib/uuid (str (random-uuid)) :base-type :type/Integer} "sum"] 1))
(lib/remove-clause 0 (first aggregations))))))))
(deftest ^:parallel remove-clause-aggregation-with-ref-test
(testing "removing an aggregation removes references in order-by (#12625)"
(let [query (-> (lib/query meta/metadata-provider (meta/table-metadata :orders))
(lib/aggregate (lib/count))
(lib/aggregate (lib/sum (meta/field-metadata :orders :total)))
(lib/aggregate (lib/sum (meta/field-metadata :orders :subtotal)))
(as-> $q (lib/order-by $q (lib/aggregation-ref $q 2))))
aggregations (lib/aggregations query)]
(is (=? {:stages [(complement :order-by)]}
(lib/remove-clause query (last aggregations))))
(let [query (lib/append-stage query)
sum-col (m/find-first (comp #{"sum_2"} :lib/desired-column-alias) (lib/visible-columns query))
query (lib/order-by query sum-col)]
(is (=? {:stages [(complement :order-by) (complement :order-by)]}
(lib/remove-clause query 0 (last aggregations))))))))
(deftest ^:parallel remove-clause-expression-test
(let [query (-> lib.tu/venues-query
(lib/expression "a" (meta/field-metadata :venues :id))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment