Skip to content
Snippets Groups Projects
Unverified Commit 2d6f8208 authored by Howon Lee's avatar Howon Lee Committed by GitHub
Browse files

Localization also works already without reference to null semantic type, here...

Localization also works already without reference to null semantic type, here is test to memorialize this (#16641)

It works, here's a test for it
parent 46845b72
No related branches found
No related tags found
No related merge requests found
......@@ -3,7 +3,7 @@ import { SAMPLE_DATASET } from "__support__/e2e/cypress_sample_dataset";
const { ORDERS, ORDERS_ID } = SAMPLE_DATASET;
describe("scenarios > admin > permissions", () => {
describe("scenarios > admin > localization", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
......
......@@ -4,6 +4,9 @@ import {
version,
popover,
} from "__support__/e2e/cypress";
import { SAMPLE_DATASET } from "__support__/e2e/cypress_sample_dataset";
const { ORDERS } = SAMPLE_DATASET;
describe("scenarios > admin > settings", () => {
beforeEach(() => {
......@@ -179,6 +182,29 @@ describe("scenarios > admin > settings", () => {
cy.contains(/^February 11, 2019, 9:40 PM$/);
});
it("should correctly apply the globalized date formats (metabase#11394)", () => {
cy.server();
cy.route("PUT", "**/custom-formatting").as("saveFormatting");
cy.request("PUT", `/api/field/${ORDERS.CREATED_AT}`, {
semantic_type: null,
});
cy.visit("/admin/settings/localization");
cy.contains("Date style")
.closest("li")
.find(".AdminSelect")
.first()
.click();
cy.findByText("2018/1/7").click();
cy.contains("17:24 (24-hour clock)").click();
cy.wait("@saveFormatting");
openOrdersTable();
cy.contains(/^2019\/2\/11, 21:40$/);
});
it("should search for and select a new timezone", () => {
cy.server();
cy.route("PUT", "**/report-timezone").as("reportTimezone");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment