Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
2dde2bfd
Commit
2dde2bfd
authored
9 years ago
by
Kyle Doherty
Browse files
Options
Downloads
Patches
Plain Diff
use inflection on table and relationships for object details
parent
6f3bd8bc
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
resources/frontend_client/app/query_builder/QueryVisualizationObjectDetailTable.react.js
+3
-3
3 additions, 3 deletions
...uery_builder/QueryVisualizationObjectDetailTable.react.js
with
3 additions
and
3 deletions
resources/frontend_client/app/query_builder/QueryVisualizationObjectDetailTable.react.js
+
3
−
3
View file @
2dde2bfd
'
use strict
'
;
import
ExpandableString
from
'
./ExpandableString.react
'
;
import
Humanize
from
'
humanize
'
;
import
Icon
from
'
metabase/components/Icon.react
'
;
import
IconBorder
from
'
metabase/components/IconBorder.react
'
;
import
LoadingSpinner
from
'
metabase/components/LoadingSpinner.react
'
;
import
{
singularize
,
inflect
}
from
'
inflection
'
;
import
cx
from
"
classnames
"
;
...
...
@@ -121,7 +121,7 @@ export default React.createClass({
<
/IconBorder
>
);
var
relationName
=
Humanize
.
pluralize
(
fkCountValue
,
fk
.
origin
.
table
.
display_name
);
var
relationName
=
inflect
(
fk
.
origin
.
table
.
display_name
,
fkCountValue
);
var
info
=
(
<
div
>
...
...
@@ -176,7 +176,7 @@ export default React.createClass({
return
false
;
}
var
tableName
=
(
this
.
props
.
tableMetadata
)
?
this
.
props
.
tableMetadata
.
display_name
:
"
Unknown
"
,
var
tableName
=
(
this
.
props
.
tableMetadata
)
?
singularize
(
this
.
props
.
tableMetadata
.
display_name
)
:
"
Unknown
"
,
// TODO: once we nail down the "title" column of each table this should be something other than the id
idValue
=
this
.
getIdValue
();
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment