Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
2e773875
Unverified
Commit
2e773875
authored
9 months ago
by
Nemanja Glumac
Committed by
GitHub
9 months ago
Browse files
Options
Downloads
Patches
Plain Diff
Repro #45036 and #44910: Multiple popovers can be opened simultaneously (#45369)
* Reproduce #45036 * Add repro for #44910
parent
e52eaee0
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
e2e/test/scenarios/collections/trash.cy.spec.js
+24
-0
24 additions, 0 deletions
e2e/test/scenarios/collections/trash.cy.spec.js
e2e/test/scenarios/question/notebook.cy.spec.js
+50
-0
50 additions, 0 deletions
e2e/test/scenarios/question/notebook.cy.spec.js
with
74 additions
and
0 deletions
e2e/test/scenarios/collections/trash.cy.spec.js
+
24
−
0
View file @
2e773875
import
{
READ_ONLY_PERSONAL_COLLECTION_ID
,
FIRST_COLLECTION_ID
,
ORDERS_COUNT_QUESTION_ID
,
ORDERS_QUESTION_ID
,
}
from
"
e2e/support/cypress_sample_instance_data
"
;
import
{
popover
,
...
...
@@ -688,6 +690,28 @@ describe("scenarios > collections > trash", () => {
assertTrashSelectedInNavigationSidebar
();
});
});
it
.
skip
(
"
should open only one context menu at a time (metabase#44910)
"
,
()
=>
{
cy
.
request
(
"
PUT
"
,
`/api/card/
${
ORDERS_QUESTION_ID
}
`
,
{
archived
:
true
});
cy
.
request
(
"
PUT
"
,
`/api/card/
${
ORDERS_COUNT_QUESTION_ID
}
`
,
{
archived
:
true
,
});
cy
.
visit
(
"
/trash
"
);
toggleEllipsisMenuFor
(
"
Orders
"
);
cy
.
findAllByRole
(
"
dialog
"
)
.
should
(
"
have.length
"
,
1
)
.
and
(
"
contain
"
,
"
Move
"
)
.
and
(
"
contain
"
,
"
Restore
"
)
.
and
(
"
contain
"
,
"
Delete permanently
"
);
toggleEllipsisMenuFor
(
"
Orders, Count
"
);
cy
.
findAllByRole
(
"
dialog
"
)
.
should
(
"
have.length
"
,
1
)
.
and
(
"
contain
"
,
"
Move
"
)
.
and
(
"
contain
"
,
"
Restore
"
)
.
and
(
"
contain
"
,
"
Delete permanently
"
);
});
});
function
toggleEllipsisMenuFor
(
item
)
{
...
...
This diff is collapsed.
Click to expand it.
e2e/test/scenarios/question/notebook.cy.spec.js
+
50
−
0
View file @
2e773875
...
...
@@ -917,6 +917,56 @@ describe("scenarios > question > notebook", { tags: "@slow" }, () => {
});
});
});
it
.
skip
(
"
should open only one bucketing popover at a time (metabase#45036)
"
,
()
=>
{
visitQuestionAdhoc
(
{
dataset_query
:
{
database
:
SAMPLE_DB_ID
,
type
:
"
query
"
,
query
:
{
"
source-table
"
:
PRODUCTS_ID
,
aggregation
:
[[
"
count
"
]]
},
parameters
:
[],
},
},
{
mode
:
"
notebook
"
},
);
getNotebookStep
(
"
summarize
"
)
.
findByText
(
"
Pick a column to group by
"
)
.
click
();
popover
()
.
findByRole
(
"
option
"
,
{
name
:
"
Created At
"
})
.
findByText
(
"
by month
"
)
.
click
();
popover
()
.
last
()
.
within
(()
=>
{
cy
.
findByText
(
"
Year
"
).
should
(
"
be.visible
"
);
cy
.
findByText
(
"
Hour of day
"
).
should
(
"
not.exist
"
);
cy
.
findByText
(
"
More…
"
).
click
();
cy
.
findByText
(
"
Hour of day
"
).
should
(
"
be.visible
"
);
});
popover
()
.
first
()
.
findByRole
(
"
option
"
,
{
name
:
"
Price
"
})
.
findByText
(
"
Auto bin
"
)
.
click
();
popover
()
.
last
()
.
within
(()
=>
{
cy
.
findByText
(
"
Auto bin
"
).
should
(
"
be.visible
"
);
cy
.
findByText
(
"
50 bins
"
).
should
(
"
be.visible
"
);
cy
.
findByText
(
"
Don't bin
"
).
should
(
"
be.visible
"
);
cy
.
findByText
(
"
Year
"
).
should
(
"
not.exist
"
);
cy
.
findByText
(
"
Hour of day
"
).
should
(
"
not.exist
"
);
cy
.
findByText
(
"
More…
"
).
should
(
"
not.exist
"
);
});
});
});
function
assertTableRowCount
(
expectedCount
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment