Unverified Commit 30b08dd1 authored 6 months ago by Ryan Laurie Committed by GitHub 6 months ago

Remove `MetabaseSettings.docsUrl()` (#47433)

* add useDocsUrl hook and update lint rule

* remove all uses of MetabaseSettings.docsUrl

* update tests

* revert non-docsurl change

parent 088f6d4e

No related branches found

No related tags found

No related merge requests found

Hide whitespace changes

Inline Side-by-side

Showing

enterprise/frontend/src/metabase-enterprise/advanced_permissions/components/ImpersonationModal/ImpersonationModalView.tsx 4 additions, 3 deletions

.../components/ImpersonationModal/ImpersonationModalView.tsx
enterprise/frontend/src/metabase-enterprise/auth/components/SettingsSAMLForm/SettingsSAMLForm.jsx 7 additions, 8 deletions

...ise/auth/components/SettingsSAMLForm/SettingsSAMLForm.jsx
frontend/lint/eslint-rules/no-unconditional-metabase-links-render.js 34 additions, 2 deletions

...nt/eslint-rules/no-unconditional-metabase-links-render.js
frontend/lint/tests/no-unconditional-metabase-links-render.unit.spec.js 33 additions, 0 deletions

...tests/no-unconditional-metabase-links-render.unit.spec.js
frontend/src/metabase/actions/components/ActionViz/ExplainerText/ExplainerText.tsx 3 additions, 7 deletions

...ions/components/ActionViz/ExplainerText/ExplainerText.tsx
frontend/src/metabase/actions/containers/ActionCreator/FormCreator/EmptyFormPlaceholder/EmptyFormPlaceholder.tsx 3 additions, 7 deletions

...FormCreator/EmptyFormPlaceholder/EmptyFormPlaceholder.tsx
frontend/src/metabase/admin/databases/components/DatabaseEditApp/Sidebar/ModelCachingControl/ModelCachingControl.tsx 3 additions, 1 deletion

...itApp/Sidebar/ModelCachingControl/ModelCachingControl.tsx
frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx 4 additions, 5 deletions

.../performance/components/ModelPersistenceConfiguration.tsx
frontend/src/metabase/admin/permissions/components/ApplicationPermissionsHelp/ApplicationPermissionsHelp.tsx 33 additions, 32 deletions

...ApplicationPermissionsHelp/ApplicationPermissionsHelp.tsx
frontend/src/metabase/admin/permissions/components/CollectionPermissionsHelp/CollectionPermissionsHelp.tsx 42 additions, 40 deletions

...s/CollectionPermissionsHelp/CollectionPermissionsHelp.tsx
frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx 3 additions, 4 deletions

...ns/components/DataPermissionsHelp/DataPermissionsHelp.tsx
frontend/src/metabase/admin/permissions/components/ToolbarUpsell/ToolbarUpsell.tsx 3 additions, 5 deletions

...in/permissions/components/ToolbarUpsell/ToolbarUpsell.tsx
frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.tsx 4 additions, 5 deletions

...base/admin/settings/auth/components/AuthCard/AuthCard.tsx
frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.unit.spec.tsx 6 additions, 6 deletions

.../settings/auth/components/AuthCard/AuthCard.unit.spec.tsx
frontend/src/metabase/admin/settings/auth/components/GoogleAuthForm/GoogleAuthForm.tsx 7 additions, 9 deletions

...ettings/auth/components/GoogleAuthForm/GoogleAuthForm.tsx
frontend/src/metabase/admin/settings/auth/components/GoogleAuthForm/GoogleAuthForm.unit.spec.tsx 4 additions, 4 deletions

...th/components/GoogleAuthForm/GoogleAuthForm.unit.spec.tsx
frontend/src/metabase/admin/settings/components/SettingsSetting.jsx 12 additions, 10 deletions

...rc/metabase/admin/settings/components/SettingsSetting.jsx
frontend/src/metabase/admin/settings/components/widgets/EmbeddingOption/EmbeddingOption.tsx 4 additions, 5 deletions

...gs/components/widgets/EmbeddingOption/EmbeddingOption.tsx
frontend/src/metabase/admin/settings/slack/components/SlackStatus/SlackStatus.tsx 3 additions, 5 deletions

...min/settings/slack/components/SlackStatus/SlackStatus.tsx
frontend/src/metabase/admin/settings/slack/components/SlackStatus/SlackStatus.unit.spec.tsx 11 additions, 4 deletions

...gs/slack/components/SlackStatus/SlackStatus.unit.spec.tsx

with 223 additions and 162 deletions

Please register or to comment