Skip to content
Snippets Groups Projects
Unverified Commit 32421f2e authored by Sloan Sparger's avatar Sloan Sparger Committed by GitHub
Browse files

Remove flaky / redundant e2e test (#42920)

parent 1ef31284
Branches
Tags v0.12.0
No related merge requests found
......@@ -24,8 +24,6 @@ import {
expectGoodSnowplowEvents,
modal,
entityPickerModal,
openCommandPalette,
commandPalette,
} from "e2e/support/helpers";
const PERMISSIONS = {
......@@ -185,39 +183,6 @@ describe(
});
});
it("should be able to archive the question (metabase#11719-3, metabase#16512, metabase#20133)", () => {
cy.intercept("GET", "/api/collection/root/items**").as(
"getItems",
);
openQuestionActions();
cy.findByTestId("archive-button").click();
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText(
"It will also be removed from the filter that uses it to populate values.",
).should("not.exist");
clickButton("Move to trash");
assertRequestNot403("updateQuestion");
assertNoPermissionsError();
cy.visit("/collection/root");
cy.wait("@getItems"); // pinned items
cy.wait("@getItems"); // unpinned items
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("Orders").should("not.exist");
openCommandPalette();
commandPalette().within(() => {
cy.findByRole("option", { name: /recent/i }).should(
"not.exist",
);
});
// Check page for archived questions
cy.visit("/question/" + ORDERS_QUESTION_ID);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.findByText("This question is in the trash.");
});
describe("Add to Dashboard", () => {
it("should be able to add question to dashboard", () => {
openQuestionActions();
......@@ -465,10 +430,6 @@ describeWithSnowplow("send snowplow question events", () => {
});
});
function clickButton(name) {
cy.button(name).should("not.be.disabled").click();
}
function assertRequestNot403(xhr_alias) {
cy.wait("@" + xhr_alias).then(xhr => {
expect(xhr.status).not.to.eq(403);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment