Previous period comparison shortcut in notebook mode (#43220)
* Sort functions * Add boilerplate for aggregateOffset and tests * Simplify assertion * Make basic case work * Handle name generation * Do not require "lib/uuid" attribute to be present since MLv2 will normalize it under the hood anyway * Fix typing * Group tests * Refactor offsetClause to return a new clause instead of a new query - Move offsetClause to expressions.ts - Add assertion * Revert "Sort functions" This reverts commit ab9ce2b24ea6bdad5ff7e9bed8ef38d4b5923f00. * Move tests * Handle names dynamically * Shorten a test * Update comment * Add TODO * Update expression types * Add diffOffsetClause & percentDiffOffsetClause * Add a test for diffOffsetClause * Add TODOs * Add tests for diffOffsetClause and percentDiffOffsetClause * Unwrap tests * Add skeleton for new tests * Refactor first offsetClause tests * Add tests for names * Fix case of non-datetime columns * Handle a case with offset < 1 and no breakouts * Handle a case with offset < 1 and breakouts on non-datetime column * Handle a case with offset < 1 and breakouts binned datetime column * Handle a case with offset < 1 and breakout on non-binned datetime column * Refactor * Refactor * Remove TODO * Add tests for diffOffsetClause * Add tests for percentDiffOffsetClause * Move offset stuff to offset.ts and offset.unit.spec.ts * Use template string for prefixes * Use breakoutColumn + isDate to check column type * Refactor * Fix error message * Add boilerplate for CompareAggregations * Fix title * Render aggregations list * Style AccordionList * Sort props * Fix bucket name * Use displayName instead shortName * Support parseValue prop in NumberInput * Add period input accepting integers only * Accept non-negative values only * Do not accept zeros * Add state * Add submit button * Export offset functions via Lib * Make it possible to skip rightSection * Add column picker * Map offset user input to api input (negative value) * Add label * Fix crash * Extract shouldCreate * Make onSelect in AggregationPicker support multiple values * Extract ReferenceAggregationPicker * Extract ColumnPicker * Extract getAggregations * Rename * Add custom items * Refactor item component * Extract OffsetInput * Remove unused data-testid * Style OffsetInput * Generate titles according to specs * Generate label * Generate help * Extract utils * Use different width for the 1st step * Format code * Use MultiSelect directly * Avoid custom parseValue * Revert MultiaAutocomplete changes * Improve typing in describeTemporalInterval and describeRelativeDatetime * Use describeTemporalUnit to pluralize * Use interface * Avoid setting value as DOM attribute * Fix test * Add onAdd prop to AggregationPicker and revert the change to have onSelect pass multiple aggregations * Reduce number of props * Render checkboxes in custom items * Introduce and use --mb-color-brand-lighter * Avoid !important * Remove redundant prop * Fix warning about isSelected being used as DOM attribute * Fix positioning in case dir attribute is not present in any parent component * Add type attribute to all ListItems
Showing
- enterprise/frontend/src/embedding-sdk/components/private/SdkContentWrapper.tsx 3 additions, 1 deletion...rc/embedding-sdk/components/private/SdkContentWrapper.tsx
- frontend/src/metabase-lib/index.ts 1 addition, 0 deletionsfrontend/src/metabase-lib/index.ts
- frontend/src/metabase-lib/offset.ts 5 additions, 5 deletionsfrontend/src/metabase-lib/offset.ts
- frontend/src/metabase-lib/temporal_bucket.ts 2 additions, 2 deletionsfrontend/src/metabase-lib/temporal_bucket.ts
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.tsx 86 additions, 13 deletions...common/components/AggregationPicker/AggregationPicker.tsx
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.unit.spec.tsx 2 additions, 0 deletions...ponents/AggregationPicker/AggregationPicker.unit.spec.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.tsx 114 additions, 0 deletions...er/components/CompareAggregations/CompareAggregations.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ColumnPicker/ColumnPicker.module.css 3 additions, 0 deletions...regations/components/ColumnPicker/ColumnPicker.module.css
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ColumnPicker/ColumnPicker.tsx 95 additions, 0 deletions...pareAggregations/components/ColumnPicker/ColumnPicker.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ColumnPicker/index.ts 1 addition, 0 deletions...ents/CompareAggregations/components/ColumnPicker/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/OffsetInput.module.css 12 additions, 0 deletions...ggregations/components/OffsetInput/OffsetInput.module.css
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/OffsetInput.tsx 52 additions, 0 deletions...ompareAggregations/components/OffsetInput/OffsetInput.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/index.ts 1 addition, 0 deletions...nents/CompareAggregations/components/OffsetInput/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/utils.ts 58 additions, 0 deletions...nents/CompareAggregations/components/OffsetInput/utils.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ReferenceAggregationPicker/ReferenceAggregationPicker.module.css 3 additions, 0 deletions...ceAggregationPicker/ReferenceAggregationPicker.module.css
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ReferenceAggregationPicker/ReferenceAggregationPicker.tsx 61 additions, 0 deletions...ReferenceAggregationPicker/ReferenceAggregationPicker.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/ReferenceAggregationPicker/index.ts 1 addition, 0 deletions...gregations/components/ReferenceAggregationPicker/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/components/index.ts 3 additions, 0 deletions...uilder/components/CompareAggregations/components/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/index.ts 2 additions, 0 deletions...ase/query_builder/components/CompareAggregations/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/types.ts 1 addition, 0 deletions...ase/query_builder/components/CompareAggregations/types.ts
Loading
Please register or sign in to comment