Skip to content
Snippets Groups Projects
Unverified Commit 33ed288f authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

Remove personal collections from collection detail page (#28879) (#29089)

* Remove personal collections from collection detail page

https://github.com/metabase/metabase/pull/28023

 Added "sub collections"
to the collection detail page. Makes sense. The problem is that personal
collections started appearing in this view. We have traditionally
treated personal collections as siblings to the "Our Analytics" root of
collections. So this was an impedence mismatch.

This PR just removes all personal collections from the items returned
from `"api/collection/root/items"`. The personal collection is still
visible in the sidebar (returned from
`api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true`
. Furthermore, all personal collections are still visible from the
"three dots" menu on the sidebar.

* poke ci

* remove last personal collections from tests

* e2e tests

don't include a personal collection in the details page.

* off by one from removing personal collections

* Can't select personal collections if they aren't there

Co-authored-by: default avatardpsutton <dan@dpsutton.com>
parent beb15627
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment