-
- Downloads
Remove personal collections from collection detail page (#28879) (#29089)
* Remove personal collections from collection detail page https://github.com/metabase/metabase/pull/28023 Added "sub collections" to the collection detail page. Makes sense. The problem is that personal collections started appearing in this view. We have traditionally treated personal collections as siblings to the "Our Analytics" root of collections. So this was an impedence mismatch. This PR just removes all personal collections from the items returned from `"api/collection/root/items"`. The personal collection is still visible in the sidebar (returned from `api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true` . Furthermore, all personal collections are still visible from the "three dots" menu on the sidebar. * poke ci * remove last personal collections from tests * e2e tests don't include a personal collection in the details page. * off by one from removing personal collections * Can't select personal collections if they aren't there Co-authored-by:dpsutton <dan@dpsutton.com>
Showing
- e2e/test/scenarios/collections/collection-items-listing.cy.spec.js 1 addition, 1 deletion...scenarios/collections/collection-items-listing.cy.spec.js
- e2e/test/scenarios/collections/collections.cy.spec.js 1 addition, 26 deletionse2e/test/scenarios/collections/collections.cy.spec.js
- src/metabase/models/collection.clj 2 additions, 4 deletionssrc/metabase/models/collection.clj
- test/metabase/api/collection_test.clj 55 additions, 71 deletionstest/metabase/api/collection_test.clj
Loading
Please register or sign in to comment