#14629 Repro: Sandboxing should work on tables with remapped FK display values (#14631)

* Make a common `describe block for related issues (FK remapping)

* Add repro for #14629

enterprise/frontend/test/metabase-enterprise/sandboxes/sandboxes.cy.spec.js

@@ -493,111 +493,153 @@ describeWithToken("formatting > sandboxes", () => {
       cy.findByText("97.44"); // Subtotal for order #10
     });
 
-    it("advanced sandboxing should not ignore data model features like object detail of FK (metabase-enterprise#520)", () => {
-      cy.log("**-- Remap Product ID's display value to `title` --**");
-
-      cy.request("POST", `/api/field/${ORDERS.PRODUCT_ID}/dimension`, {
-        field_id: ORDERS.PRODUCT_ID,
-        name: "Product ID",
-        human_readable_field_id: PRODUCTS.TITLE,
-        type: "external",
+    describe("with display values remapped to use a foreign key", () => {
+      beforeEach(() => {
+        cy.log("**-- Remap Product ID's display value to `title` --**");
+
+        cy.request("POST", `/api/field/${ORDERS.PRODUCT_ID}/dimension`, {
+          field_id: ORDERS.PRODUCT_ID,
+          name: "Product ID",
+          human_readable_field_id: PRODUCTS.TITLE,
+          type: "external",
+        });
       });
-      cy.log("**-- 1. Create the first native question with a filter --**");
 
-      cy.request("POST", "/api/card", {
-        name: "EE_520_Q1",
-        dataset_query: {
-          database: 1,
-          native: {
-            query:
-              "SELECT * FROM ORDERS WHERE USER_ID={{sandbox}} AND TOTAL>10",
-            "template-tags": {
-              sandbox: {
-                "display-name": "Sandbox",
-                id: "1115dc4f-6b9d-812e-7f72-b87ab885c88a",
-                name: "sandbox",
-                type: "number",
+      it("advanced sandboxing should not ignore data model features like object detail of FK (metabase-enterprise#520)", () => {
+        cy.log("**-- 1. Create the first native question with a filter --**");
+
+        cy.request("POST", "/api/card", {
+          name: "EE_520_Q1",
+          dataset_query: {
+            database: 1,
+            native: {
+              query:
+                "SELECT * FROM ORDERS WHERE USER_ID={{sandbox}} AND TOTAL>10",
+              "template-tags": {
+                sandbox: {
+                  "display-name": "Sandbox",
+                  id: "1115dc4f-6b9d-812e-7f72-b87ab885c88a",
+                  name: "sandbox",
+                  type: "number",
+                },
               },
             },
+            type: "native",
           },
-          type: "native",
-        },
-        display: "table",
-        visualization_settings: {},
-      }).then(({ body: { id: CARD_ID } }) => {
-        cy.log("**-- 1a. Sandbox `Orders` table based on this question --**");
-
-        cy.request("POST", "/api/mt/gtap", {
-          attribute_remappings: {
-            [ATTR_UID]: ["variable", ["template-tag", "sandbox"]],
-          },
-          card_id: CARD_ID,
-          group_id: COLLECTION_GROUP,
-          table_id: ORDERS_ID,
+          display: "table",
+          visualization_settings: {},
+        }).then(({ body: { id: CARD_ID } }) => {
+          cy.log("**-- 1a. Sandbox `Orders` table based on this question --**");
+
+          cy.request("POST", "/api/mt/gtap", {
+            attribute_remappings: {
+              [ATTR_UID]: ["variable", ["template-tag", "sandbox"]],
+            },
+            card_id: CARD_ID,
+            group_id: COLLECTION_GROUP,
+            table_id: ORDERS_ID,
+          });
         });
-      });
-      cy.log("**-- 2. Create the second native question with a filter --**");
-
-      cy.request("POST", "/api/card", {
-        name: "EE_520_Q2",
-        dataset_query: {
-          database: 1,
-          native: {
-            query:
-              "SELECT * FROM PRODUCTS↵WHERE CATEGORY={{sandbox}} AND PRICE>10",
-            "template-tags": {
-              sandbox: {
-                "display-name": "Sandbox",
-                id: "3d69ba99-7076-2252-30bd-0bb8810ba895",
-                name: "sandbox",
-                type: "text",
+        cy.log("**-- 2. Create the second native question with a filter --**");
+
+        cy.request("POST", "/api/card", {
+          name: "EE_520_Q2",
+          dataset_query: {
+            database: 1,
+            native: {
+              query:
+                "SELECT * FROM PRODUCTS↵WHERE CATEGORY={{sandbox}} AND PRICE>10",
+              "template-tags": {
+                sandbox: {
+                  "display-name": "Sandbox",
+                  id: "3d69ba99-7076-2252-30bd-0bb8810ba895",
+                  name: "sandbox",
+                  type: "text",
+                },
               },
             },
+            type: "native",
           },
-          type: "native",
-        },
-        display: "table",
-        visualization_settings: {},
-      }).then(({ body: { id: CARD_ID } }) => {
-        cy.log("**-- 2a. Sandbox `Products` table based on this question --**");
+          display: "table",
+          visualization_settings: {},
+        }).then(({ body: { id: CARD_ID } }) => {
+          cy.log(
+            "**-- 2a. Sandbox `Products` table based on this question --**",
+          );
+
+          cy.request("POST", "/api/mt/gtap", {
+            attribute_remappings: {
+              [ATTR_CAT]: ["variable", ["template-tag", "sandbox"]],
+            },
+            card_id: CARD_ID,
+            group_id: COLLECTION_GROUP,
+            table_id: PRODUCTS_ID,
+          });
+        });
 
-        cy.request("POST", "/api/mt/gtap", {
-          attribute_remappings: {
-            [ATTR_CAT]: ["variable", ["template-tag", "sandbox"]],
+        updatePermissionsGraph({
+          schema: {
+            [PRODUCTS_ID]: { query: "segmented", read: "all" },
+            [ORDERS_ID]: { query: "segmented", read: "all" },
           },
-          card_id: CARD_ID,
-          group_id: COLLECTION_GROUP,
-          table_id: PRODUCTS_ID,
         });
-      });
 
-      updatePermissionsGraph({
-        schema: {
-          [PRODUCTS_ID]: { query: "segmented", read: "all" },
-          [ORDERS_ID]: { query: "segmented", read: "all" },
-        },
+        signOut();
+        signInAsSandboxedUser();
+
+        openOrdersTable();
+
+        cy.log("**-- Reported failing on v1.36.x --**");
+
+        cy.log(
+          "**It should show remapped Display Values instead of Product ID**",
+        );
+        cy.get(".cellData")
+          .contains("Awesome Concrete Shoes")
+          .click();
+        cy.findByText(/View details/i).click();
+
+        cy.log(
+          "**It should show object details instead of filtering by this Product ID**",
+        );
+        // The name of this Vendor is visible in "details" only
+        cy.findByText("McClure-Lockman");
       });
 
-      signOut();
-      signInAsSandboxedUser();
+      it.skip("simple sandboxing should work (metabase#14629)", () => {
+        cy.server();
+        cy.route("POST", "/api/dataset").as("dataset");
+
+        cy.log(
+          "**-- 1. Sandbox `Orders` table based on user attribute `attr_uid` --**",
+        );
 
-      openOrdersTable();
+        cy.request("POST", "/api/mt/gtap", {
+          table_id: ORDERS_ID,
+          group_id: COLLECTION_GROUP,
+          card_id: null,
+          attribute_remappings: {
+            [ATTR_UID]: ["dimension", ["field-id", ORDERS.PRODUCT_ID]],
+          },
+        });
 
-      cy.log("**-- Reported failing on v1.36.x --**");
+        updatePermissionsGraph({
+          schema: {
+            [ORDERS_ID]: { query: "segmented", read: "all" },
+            [PRODUCTS_ID]: "all",
+          },
+        });
 
-      cy.log(
-        "**It should show remapped Display Values instead of Product ID**",
-      );
-      cy.get(".cellData")
-        .contains("Awesome Concrete Shoes")
-        .click();
-      cy.findByText(/View details/i).click();
+        signOut();
+        signInAsSandboxedUser();
+        openOrdersTable();
 
-      cy.log(
-        "**It should show object details instead of filtering by this Product ID**",
-      );
-      // The name of this Vendor is visible in "details" only
-      cy.findByText("McClure-Lockman");
+        cy.wait("@dataset").then(xhr => {
+          expect(xhr.response.body.error).not.to.exist;
+        });
+        // Title of the Product ID = 1
+        cy.findAllByText("Rustic Paper Wallet");
+      });
     });
 
     it.skip("should work on questions with joins, with sandboxed target table, where target fields cannot be filtered (metabase#13642)", () => {