manual backport #29112 (#29174)

enterprise/backend/test/metabase_enterprise/advanced_config/api/logs_test.clj

-(ns metabase-enterprise.advanced-config.api.logs-test
+(ns ^:mb/once metabase-enterprise.advanced-config.api.logs-test
   "Tests for /api/ee/logs endpoints"
   (:require
    [clojure.test :refer :all]
    [java-time :as t]
+   [metabase-enterprise.advanced-config.api.logs :as ee.api.logs]
    [metabase.models.query-execution :refer [QueryExecution]]
    [metabase.public-settings.premium-features-test :as premium-features.test]
    [metabase.query-processor.util :as qp.util]
@@ -22,20 +23,33 @@
   (testing "GET /api/logs/query_execution/:yyyy-mm"
     (let [test-user :crowberto
           user-id   (mt/user->id test-user)]
-      (mt/with-temp* [QueryExecution [qe-a (merge query-execution-defaults
-                                                  {:executor_id user-id
-                                                   :started_at  (t/minus now (t/days 2))})]
-                      QueryExecution [qe-b (merge query-execution-defaults
-                                                   {:executor_id user-id
-                                                    :started_at  (t/minus now (t/days 32))})]]
-        (testing "Query Executions within `:yyyy-mm` are returned."
+      ;; QueryExecution is an unbounded mega table and query it could result in a full table scan :( (See: #29103)
+      ;; Run the test in an empty database to make querying less intense.
+      (mt/with-empty-h2-app-db
+        (mt/with-temp* [QueryExecution [qe-a (merge query-execution-defaults
+                                                    {:executor_id user-id
+                                                     :started_at  (t/minus now (t/days 2))})]
+                        QueryExecution [qe-b (merge query-execution-defaults
+                                                    {:executor_id user-id
+                                                     :started_at  (t/minus now (t/days 32))})]]
           (premium-features.test/with-premium-features #{:advanced-config}
-            (is (= [(select-keys qe-a [:started_at :id])]
-                   (->> (mt/user-http-request test-user :get 200 "ee/logs/query_execution/2023-02")
-                        (filter #(#{user-id} (:executor_id %)))
-                        (filter #((set (map :id [qe-a qe-b])) (:id %)))
-                        (map #(select-keys % [:started_at :id])))))))
-        (testing "Logs endpoint only works when `:advanced-config` feature is available."
-          (premium-features.test/with-premium-features #{}
-            (is (= "This API endpoint is only enabled if you have a premium token with the :advanced-config feature."
-                   (mt/user-http-request test-user :get 402 "ee/logs/query_execution/2023-02")))))))))
+            (testing "Query Executions within `:yyyy-mm` are returned."
+              (is (= [(select-keys qe-a [:started_at :id])]
+                     ;; we're calling the function directly instead of calling the API
+                     ;; because we want the test to run against the empty h2 DB we bound above
+                     ;; Until we figure out how to completely re-bind a database for API calls
+                     ;; this should be enough
+                     (->> (ee.api.logs/query-execution-logs 2023 2)
+                          (filter #(#{user-id} (:executor_id %)))
+                          (filter #((set (map :id [qe-a qe-b])) (:id %)))
+                          (map #(select-keys % [:started_at :id]))))))))))
+
+    (testing "permission tests"
+      (testing "require admins"
+        (premium-features.test/with-premium-features #{:advanced-config}
+          (is (= "You don't have permissions to do that."
+                 (mt/user-http-request :rasta :get 403 "ee/logs/query_execution/2023-02")))))
+      (testing "only works when `:advanced-config` feature is available."
+        (premium-features.test/with-premium-features #{}
+          (is (= "This API endpoint is only enabled if you have a premium token with the :advanced-config feature."
+                 (mt/user-http-request :crowberto :get 402 "ee/logs/query_execution/2023-02"))))))))

test/metabase/test/data.clj

@@ -257,6 +257,7 @@
 
   Makes use of functionality in the [[metabase.db.schema-migrations-test.impl]] namespace since that already does what
   we need."
+  {:style/indent 0}
   [& body]
   `(schema-migrations-test.impl/with-temp-empty-app-db [conn# :h2]
      (schema-migrations-test.impl/run-migrations-in-range! conn# [0 "v99.00-000"]) ; this should catch all migrations)