Skip to content
Snippets Groups Projects
Unverified Commit 36b71d89 authored by Sameer Al-Sakran's avatar Sameer Al-Sakran Committed by GitHub
Browse files

Merge pull request #7422 from metabase/fix_is_not

Fix is_not filters causing errors on generating dashboards
parents 6c9ef64d 50c51a71
No related branches found
No related tags found
No related merge requests found
......@@ -181,7 +181,7 @@
(format "is on %s" (humanize-datetime value))
(format "is %s" (apply either value values)))}]))
(defmethod humanize-filter-value :not=
(defmethod humanize-filter-value :!=
[[_ field-reference value]]
[{:field field-reference
:value (format "is not %s" value)}])
......
......@@ -127,6 +127,22 @@
(automagic-analysis {:cell-query [:= [:field-id (data/id :venues :category_id) 2]]})
valid-dashboard?)))))
(expect
true
(tt/with-temp* [Card [{card-id :id} {:table_id (data/id :venues)
:dataset_query {:query {:filter [:> [:field-id (data/id :venues :price)] 10]
:source_table (data/id :venues)}
:type :query
:database (data/id)}}]]
(with-rasta
(with-dashboard-cleanup
(-> card-id
Card
(automagic-analysis {:cell-query [:!= [:field-id (data/id :venues :category_id) 2]]})
valid-dashboard?)))))
(expect
true
(with-rasta
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment