Fix 'null' initial value for name field in new question save form (#31865)

* Fix 'null' initial value for name field in new question save form

* Refactored test to use common api

frontend/src/metabase/containers/SaveQuestionModal.tsx

@@ -118,7 +118,7 @@ export default class SaveQuestionModal extends Component<SaveQuestionModalProps>
     const isReadonly = originalQuestion != null && !originalQuestion.canWrite();
 
     const initialValues: FormValues = {
-      name: question.generateQueryDescription(),
+      name: question.generateQueryDescription() || "",
       description: question.description() || "",
       collection_id:
         question.collectionId() === undefined || isReadonly

frontend/src/metabase/containers/SaveQuestionModal.unit.spec.tsx

@@ -2,7 +2,12 @@ import fetchMock from "fetch-mock";
 import userEvent from "@testing-library/user-event";
 
 import { createMockMetadata } from "__support__/metadata";
-import { renderWithProviders, screen, waitFor } from "__support__/ui";
+import {
+  getBrokenUpTextMatcher,
+  renderWithProviders,
+  screen,
+  waitFor,
+} from "__support__/ui";
 import { setupEnterpriseTest } from "__support__/enterprise";
 import { mockSettings } from "__support__/settings";
 
@@ -387,6 +392,51 @@ describe("SaveQuestionModal", () => {
         expect(screen.getByRole("button", { name: "Save" })).toBeDisabled();
       });
     });
+
+    it("should show humanized validation message for saving a native query question", async () => {
+      await setup(
+        new Question(
+          {
+            dataset_query: {
+              type: "native",
+              database: ORDERS_ID,
+              native: {
+                query: "select * from orders",
+              },
+              display: "table",
+            },
+          },
+          metadata,
+        ),
+      );
+
+      const inputEl = screen.getByLabelText("Name");
+      userEvent.click(inputEl);
+      userEvent.tab();
+
+      expect(
+        screen.getByText(getBrokenUpTextMatcher("Name: required"), {
+          selector: "label",
+        }),
+      ).toBeInTheDocument();
+    });
+
+    it("should show humanized validation message for saving a structured query question", async () => {
+      await setup(getQuestion());
+
+      const inputEl = screen.getByLabelText("Name");
+      userEvent.click(inputEl);
+      userEvent.clear(inputEl); // remove autogenerated name
+      userEvent.tab();
+
+      await waitFor(() => {
+        expect(
+          screen.getByText(getBrokenUpTextMatcher("Name: required"), {
+            selector: "label",
+          }),
+        ).toBeInTheDocument();
+      });
+    });
   });
 
   describe("overwriting a saved question", () => {