Skip to content
Snippets Groups Projects
Unverified Commit 3a400e4e authored by Alexander Polyankin's avatar Alexander Polyankin Committed by GitHub
Browse files

Allow using some string filters for fields without special type (#21920)

parent 51f439af
No related branches found
No related tags found
No related merge requests found
......@@ -4,7 +4,6 @@ import { TemplateTagVariable } from "metabase-lib/lib/Variable";
export function fieldFilterForParameter(parameter) {
const type = getParameterType(parameter);
const subtype = getParameterSubType(parameter);
switch (type) {
case "date":
return field => field.isDate();
......@@ -17,11 +16,7 @@ export function fieldFilterForParameter(parameter) {
case "number":
return field => field.isNumber() && !field.isCoordinate();
case "string":
return field => {
return subtype === "=" || subtype === "!="
? field.isCategory() && !field.isLocation()
: field.isString() && !field.isLocation();
};
return field => field.isString() && !field.isLocation();
}
return () => false;
......
......@@ -71,6 +71,7 @@ describe("parameters/utils/field-filters", () => {
type: "category",
field: () => ({
...field,
isString: () => true,
isCategory: () => true,
}),
},
......@@ -81,6 +82,7 @@ describe("parameters/utils/field-filters", () => {
type: "category",
field: () => ({
...field,
isString: () => true,
isCategory: () => true,
}),
},
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment