Merge pull request #1168 from metabase/illustration_icon_consistency

consistent illustration icon usage

frontend/src/card/actions.js

@@ -79,7 +79,6 @@ export const fetchCards = createThunkAction(FETCH_CARDS, function(filterMode, fi
         for (var c of cards) {
             c.created_at = moment(c.created_at);
             c.updated_at = moment(c.updated_at);
-            c.icon = c.display ? 'illustration_visualization_' + c.display : null;
         }
         return cards;
     };

frontend/src/card/components/Cards.react.js

@@ -42,7 +42,7 @@ export default class Cards extends Component {
                 {items.map(item =>
                     <li key={item.id} className="flex pt2">
                         <div className="pb2 mr2">
-                            <img style={{height: "36px"}} src={"/app/components/icons/assets/" + item.icon + ".png"} />
+                            <Icon name={'illustration-'+item.display} width={36} height={36} />
                         </div>
                         <div className="flex align-center flex-full border-bottom pb2">
                             <div className="text-brand-hover">

frontend/src/components/SortableItemList.react.js

+import Icon from "metabase/components/Icon.react";
 import RadioSelect from 'metabase/components/RadioSelect.react';
 
+
 export default class SortableItemList extends React.Component {
     constructor(props) {
         super(props);
@@ -39,7 +41,7 @@ export default class SortableItemList extends React.Component {
                             <a className="no-decoration flex p2" href="#" onClick={() => this.onClickItem(item)}>
                                 <div className="flex align-center flex-full mr2">
                                     {this.props.showIcons ?
-                                        <div><img className="mr2" style={{height: "48px"}}  src={"/app/components/icons/assets/" + item.icon + ".png"} /></div>
+                                        <div className="mr2"><Icon name={'illustration-'+item.display} width={48} height={48} /></div>
                                     : null}
                                     <div className="text-brand-hover">
                                         <h3 className="mb1">{item.name}</h3>

frontend/src/dashboard/actions.js

@@ -88,7 +88,6 @@ export const fetchCards = createThunkAction(FETCH_CARDS, function(filterMode = "
         let cards = await Card.list({ filterMode });
         for (var c of cards) {
             c.updated_at = moment(c.updated_at);
-            c.icon = c.display ? 'illustration_visualization_' + c.display : null;
         }
         return normalize(cards, arrayOf(card));
     };

frontend/src/home/components/RecentViews.react.js

@@ -24,9 +24,8 @@ export default class RecentViews extends Component {
 
     renderIllustration(item) {
         if (item.model === 'card' && 'display' in item.model_object) {
-            const icon = (item.model_object.display === 'line') ? 'illustration-area' : 'illustration-'+item.model_object.display;
             return (
-                <Icon name={icon} width={22} height={22} />
+                <Icon name={'illustration-'+item.model_object.display} width={22} height={22} />
             );
 
         } else if(item.model === 'dashboard') {