Fix incorrect table names on join dimensions (#17976)

* Add reproduction for #17968

* Fix showing incorrect join field table names

* Test previous results str

frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.jsx

@@ -540,10 +540,7 @@ const joinDimensionCellItemPropTypes = {
 };
 
 function getDimensionSourceName(dimension) {
-  return dimension
-    .query()
-    .table()
-    .displayName();
+  return dimension.field()?.table?.display_name || t`Previous results`;
 }
 
 function getDimensionDisplayName(dimension) {

frontend/test/metabase/scenarios/question/joins.cy.spec.js

@@ -106,6 +106,25 @@ describe("scenarios > question > joined questions", () => {
     // (orders joined with products on the same day-month-year)
     cy.get(".ScalarValue").contains("2,087");
   });
+
+  it("should show 'Previous results' instead of a table name for non-field dimensions", () => {
+    cy.intercept("POST", "/api/dataset").as("dataset");
+    openOrdersTable({ mode: "notebook" });
+
+    cy.findByText("Summarize").click();
+    selectFromDropdown("Count of rows");
+
+    cy.findByText("Pick a column to group by").click();
+    selectFromDropdown("Created At");
+
+    cy.findByText("Join data").click();
+    selectFromDropdown("Products");
+    selectFromDropdown("Count");
+
+    cy.findByTestId("step-join-1-0")
+      .findByTestId("parent-dimension")
+      .findByText("Previous results");
+  });
 });
 
 function joinTable(table) {

frontend/test/metabase/scenarios/question/reproductions/17968-notebook-join-table-names.cy.spec.js

+import { restore, popover, openOrdersTable } from "__support__/e2e/cypress";
+
+describe("issue 17968", () => {
+  beforeEach(() => {
+    cy.intercept("POST", "/api/dataset").as("dataset");
+    restore();
+    cy.signInAsAdmin();
+  });
+
+  it("shows correct table names when joining many tables (metabase#17968)", () => {
+    openOrdersTable({ mode: "notebook" });
+
+    cy.findByText("Join data").click();
+    popover()
+      .findByText("Products")
+      .click();
+
+    cy.findByTestId("action-buttons")
+      .findByText("Join data")
+      .click();
+    popover()
+      .findByText("Reviews")
+      .click();
+
+    popover().within(() => {
+      cy.findByText("Products").click();
+      cy.findByText("ID").click();
+    });
+
+    popover()
+      .findByText("Product ID")
+      .click();
+
+    cy.findByTestId("step-join-0-1")
+      .findByTestId("parent-dimension")
+      .findByText("Products");
+  });
+});