Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
3eb0d2c2
Unverified
Commit
3eb0d2c2
authored
3 years ago
by
Noah Moss
Committed by
GitHub
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Fix test for inclusion of global viz settings in viz settings middleware (#21188)
parent
9d6d5609
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
test/metabase/query_processor/middleware/visualization_settings_test.clj
+13
-10
13 additions, 10 deletions
...uery_processor/middleware/visualization_settings_test.clj
with
13 additions
and
10 deletions
test/metabase/query_processor/middleware/visualization_settings_test.clj
+
13
−
10
View file @
3eb0d2c2
...
...
@@ -118,14 +118,17 @@
result
(
update-viz-settings
query
)]
(
is
(
=
test-native-query-viz-settings
result
)))))
(
deftest
includes-global-settings
(
testing
"Viz settings include global viz settings"
(
deftest
includes-global-settings
-test
(
testing
"Viz settings include global viz settings
, in a normalized form
"
(
mt/with-temp*
[
Field
[{
field-id-1
:id
}]
Field
[{
field-id-2
:id
}]]
(
let
[
query
(
test-query
[
field-id-1
field-id-2
]
nil
nil
)
result
(
update-viz-settings
query
false
)
expected
(
assoc
(
processed-viz-settings
field-id-1
field-id-2
)
::mb.viz/global-column-settings
#
:type
{
:Number
{
::mb.viz/number_separators
".,"
}
:Currency
{
::mb.viz/currency
"BIF"
::mb.viz/currency_style
"code"
}})]))))
Field
[{
field-id-2
:id
}]
Card
[{
card-id
:id
}
{
:visualization_settings
(
db-viz-settings
field-id-1
field-id-2
)}]]
(
let
[
global-viz-settings
#
:type
{
:Number
{
:number_separators
".,"
}
:Currency
{
:currency
"BIF"
}}]
(
mt/with-temporary-setting-values
[
custom-formatting
global-viz-settings
]
(
let
[
query
(
test-query
[
field-id-1
field-id-2
]
card-id
nil
)
result
(
update-viz-settings
query
false
)
expected
(
assoc
(
processed-viz-settings
field-id-1
field-id-2
)
::mb.viz/global-column-settings
#
:type
{
:Number
{
::mb.viz/number-separators
".,"
}
:Currency
{
::mb.viz/currency
"BIF"
}})]
(
is
(
=
expected
result
))))))))
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment