-
- Downloads
Indicate field for database error (#22804)
* Indicate field responsible for database error
* Implement new interface
* Make error showing logic a little easier to understand
* Show individual field error in database form
* Add backend tests for connection errors when adding a database
* Add new form error component
* Make database form error message pretty
* Make main database form error message field bold
* Change create account database form according to feedback
* Fix failed E2E tests from UI changed.
* Make it easier to tree-shake "lodash"
* Change according to PR review
* Cleanup + remove FormError (to be included in a separate PR)
Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
Showing
- frontend/src/metabase/admin/databases/containers/DatabaseEditApp.jsx 20 additions, 1 deletion...c/metabase/admin/databases/containers/DatabaseEditApp.jsx
- frontend/src/metabase/components/form/CustomForm/CustomFormSubmit.tsx 1 addition, 1 deletion.../metabase/components/form/CustomForm/CustomFormSubmit.tsx
- frontend/src/metabase/components/form/FormField/FormField.tsx 2 additions, 2 deletions...tend/src/metabase/components/form/FormField/FormField.tsx
- frontend/src/metabase/containers/Form.jsx 4 additions, 1 deletionfrontend/src/metabase/containers/Form.jsx
- frontend/src/metabase/setup/components/DatabaseStep/DatabaseStep.styled.tsx 6 additions, 0 deletions...ase/setup/components/DatabaseStep/DatabaseStep.styled.tsx
- frontend/src/metabase/setup/components/DatabaseStep/DatabaseStep.tsx 22 additions, 7 deletions...c/metabase/setup/components/DatabaseStep/DatabaseStep.tsx
- frontend/src/metabase/setup/components/DatabaseStep/types.ts 10 additions, 0 deletionsfrontend/src/metabase/setup/components/DatabaseStep/types.ts
- frontend/test/metabase/scenarios/onboarding/setup/setup.cy.spec.js 2 additions, 2 deletions...test/metabase/scenarios/onboarding/setup/setup.cy.spec.js
- frontend/test/metabase/scenarios/smoketest/admin.cy.spec.js 1 addition, 1 deletionfrontend/test/metabase/scenarios/smoketest/admin.cy.spec.js
- modules/drivers/mongo/src/metabase/driver/mongo.clj 7 additions, 7 deletionsmodules/drivers/mongo/src/metabase/driver/mongo.clj
- modules/drivers/presto/src/metabase/driver/presto.clj 3 additions, 4 deletionsmodules/drivers/presto/src/metabase/driver/presto.clj
- modules/drivers/snowflake/src/metabase/driver/snowflake.clj 1 addition, 1 deletionmodules/drivers/snowflake/src/metabase/driver/snowflake.clj
- src/metabase/api/database.clj 16 additions, 18 deletionssrc/metabase/api/database.clj
- src/metabase/api/setup.clj 4 additions, 6 deletionssrc/metabase/api/setup.clj
- src/metabase/driver.clj 4 additions, 3 deletionssrc/metabase/driver.clj
- src/metabase/driver/common.clj 0 additions, 44 deletionssrc/metabase/driver/common.clj
- src/metabase/driver/h2.clj 3 additions, 3 deletionssrc/metabase/driver/h2.clj
- src/metabase/driver/mysql.clj 4 additions, 4 deletionssrc/metabase/driver/mysql.clj
- src/metabase/driver/postgres.clj 5 additions, 5 deletionssrc/metabase/driver/postgres.clj
- src/metabase/driver/util.clj 87 additions, 5 deletionssrc/metabase/driver/util.clj
Loading
Please register or sign in to comment