Update new BigQuery driver to only use project-id in qualified names if it...
Update new BigQuery driver to only use project-id in qualified names if it differs from credentials (#18843) * Update new BigQuery driver to only use project-id in qualified names if it differs from credentials Add new key to db-details for :bigquery-cloud-sdk when a database is updated, called :project-id-from-credentials, and extract the project-id from the service account creds when the database is saved Updating logic in bigquery-cloud-sdk QP to only include the project-id when qualifying an Identifier, if the project-id (override) value is set, and its value differs from the :project-id-from-credentials value mentioned above Adding a test to confirm that a card query continues to work after changing the associated DB's driver from :bigquery to :bigquery-cloud-sdk Change all syncs in the test to {:scan :schema} to speed them up (deeper level not needed)
Showing
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj 7 additions, 10 deletions...uery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.clj 37 additions, 1 deletion...oud-sdk/src/metabase/driver/bigquery_cloud_sdk/common.clj
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk/query_processor.clj 17 additions, 2 deletions...rc/metabase/driver/bigquery_cloud_sdk/query_processor.clj
- modules/drivers/bigquery-cloud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj 39 additions, 10 deletions...loud-sdk/test/metabase/driver/bigquery_cloud_sdk_test.clj
Loading
Please register or sign in to comment