-
- Downloads
X ray stage 1 (#34026)
* reintroduce the functions
* using affinities
had to update the affinities map to handle multiple definitions of the
same affinity name.
```clojure
core=> (let [affinities (-> ["table" "GenericTable"]
dashboard-templates/get-dashboard-template
dash-template->affinities-map)]
(affinities "HourOfDayCreateDate"))
[["HourOfDayCreateDate"
{:dimensions ["CreateTimestamp"], :metrics ["Count"], :score 50}]
["HourOfDayCreateDate"
{:dimensions ["CreateTime"], :metrics ["Count"], :score 50}]]
```
Here there were two cards defined as "HourOfDateCreateDate". One looked
for a createtimestamp, the other for a createtime. When treating the
affinities as unique names, the one with createtime clobbered the
createtimestamp and then it went unsatisfied.
Now we keep both definitions around. The group by is stable so the
timestamp comes first and in match that one will be matched.
* i don't like reduced for some reason
* fixup affinities
1. Affinities were in wrong shape:
before:
```clojure
{"card-name" [["card-name" definition]
["card-name" definition]]
,,,
```
new shape:
```clojure
{"card-name" [definition
definition]
,,,
```
ex:
```clojure
core=> (let [affinities (-> ["table" "GenericTable"]
dashboard-templates/get-dashboard-template
dash-template->affinities-map)]
(affinities "HourOfDayCreateDate"))
({:dimensions ["CreateTimestamp"], :metrics ["Count"], :score 50}
{:dimensions ["CreateTime"], :metrics ["Count"], :score 50})
```
2. Erroring on unfindable filters/metrics
using `{:filter [:dimension ::unsatisfiable]}` didn't work correctly
because of this:
```clojure
;; it doesn't look for dimensions by keyword
core=> (dashboard-templates/collect-dimensions [:dimension ::nope])
()
core=> (dashboard-templates/collect-dimensions [:dimension (str ::nope)])
(":metabase.automagic-dashboards.core/nope")
```
* Updating dash-template->affinities-map to dash-template->affinities.
Two key changes were made:
- The card name is now a part of the 'affinity' object (under the `:affinity-name` key).
This flattening should also make affinities easier to deal with and more flexible
(e.g. arbitrary groupings).
- All base dimensions are exploded out into these affinity objects under the `:base-dims` key.
Note that this may result in growth of the number of affinities when named items are
repeated with different definitions. For example, card names are not unique, resulting in
N affinities per card. Also, metrics and filters need not be unique. GenericTable, for
example, has 6 definitions of the Last30Days filter. This will result in 6X the number of
affinities created for each card using that filter.
This change encapsulates affinities, as before you'd need to know what dimensions underlied
any given metric or filter. ATM, we do not package each filter or metric definition in each
affinity object, but perhaps that would be worth doing in the future for complete encapsulation.
This change also allows for very simple matching logic. To match card affinities, for example,
you just filter all affinities for which the affinity dimensions are a subset of the provided
dimensions.
* Updated tests for new affinity code. Removed accidental cruft.
* Change shape of affinities
The "satisfied-affins" are of this shape:
```clojure
{"AverageIncomeByMonth" #{"Income" "Timestamp"},
"AverageDiscountByMonth" #{"Income" "Discount" "Timestamp"}}
```
And they are ordered so it can drive the `make-cards` function in the
future. The idea is for right now we'll look up the card based on
affinity name, and when multiple cards found, the set of dimensions they
depend on. And that will drive the layout.
But in the future, just the affinity itself will drive how we make a
card layout. This is the firs step towards that.
* Satisfied-affinities shape is ordered map to vector of sets of dims
```clojure
{"RowcountLast30Days" [#{"CreateTimestamp"}],
"Rowcount" [#{}]}
```
Since each could be met in a few definitions in multiple ways
* Update comment
```clojure
core=> (let [affinities (-> ["table" "GenericTable"]
dashboard-templates/get-dashboard-template
dash-template->affinities)]
(match-affinities affinities {:available-dimensions {"JoinDate" :whatever}}))
{"Rowcount" [#{}],
"RowcountLast30Days" [#{"JoinDate"}],
"CountByJoinDate" [#{"JoinDate"}],
"DayOfWeekJoinDate" [#{"JoinDate"}],
"DayOfMonthJoinDate" [#{"JoinDate"}],
"MonthOfYearJoinDate" [#{"JoinDate"}],
"QuerterOfYearJoinDate" [#{"JoinDate"}]}
```
* comment block is helpful 
Mark Bastian <markbastian@gmail.com>
Showing
- src/metabase/automagic_dashboards/core.clj 277 additions, 95 deletionssrc/metabase/automagic_dashboards/core.clj
- src/metabase/automagic_dashboards/schema.clj 189 additions, 0 deletionssrc/metabase/automagic_dashboards/schema.clj
- test/metabase/automagic_dashboards/core_test.clj 185 additions, 203 deletionstest/metabase/automagic_dashboards/core_test.clj
src/metabase/automagic_dashboards/schema.clj
0 → 100644
This diff is collapsed.
Please register or sign in to comment