Omit :effective-type from legacy MBQL queries (#30469)

* Omit :effective-type from legacy MBQL queries

Fixes #30461.

src/metabase/lib/convert.cljc

@@ -326,7 +326,7 @@
                     [id opts])]
     [:field
      (->legacy-MBQL id)
-     (not-empty (disqualify opts))]))
+     (options->legacy-MBQL opts)]))
 
 (defmethod ->legacy-MBQL :value
   [[_tag opts value]]

test/metabase/lib/convert_test.cljc

@@ -140,10 +140,11 @@
                  :stages   [{:lib/type     :mbql.stage/mbql
                              :source-table 1
                              :aggregation  [[:sum {:lib/uuid ag-uuid}
-                                             [:field {:lib/uuid string?} 1]]]
+                                             [:field {:lib/uuid string?
+                                                      :effective-type :type/Integer} 1]]]
                              :breakout     [[:aggregation
                                              {:display-name   "Revenue"
-                                              :effective_type :type/Integer}
+                                              :effective-type :type/Integer}
                                              ag-uuid]]}]}))))))
 
 (deftest ^:parallel round-trip-test