Skip to content
Snippets Groups Projects
Unverified Commit 43937aae authored by Ariya Hidayat's avatar Ariya Hidayat Committed by GitHub
Browse files

Derive parameter operator, not passing it as a prop (#22570)

parent 91b635de
No related branches found
No related tags found
No related merge requests found
......@@ -19,7 +19,6 @@ import { fetchField, fetchFieldValues } from "metabase/redux/metadata";
import { getMetadata } from "metabase/selectors/metadata";
import { getParameterIconName } from "metabase/parameters/utils/ui";
import { deriveFieldOperatorFromParameter } from "metabase/parameters/utils/operators";
import { isDashboardParameterWithoutMapping } from "metabase/parameters/utils/dashboards";
import { hasFieldValues } from "metabase/parameters/utils/fields";
......@@ -306,7 +305,6 @@ function Widget({
setValue={setValue}
isEditing={isEditing}
focusChanged={onFocusChanged}
operator={deriveFieldOperatorFromParameter(parameter)}
/>
);
} else {
......
......@@ -12,6 +12,8 @@ import Button from "metabase/core/components/Button";
import { normalizeValue } from "./normalizeValue";
import { deriveFieldOperatorFromParameter } from "metabase/parameters/utils/operators";
import cx from "classnames";
import {
getFilterArgumentFormatOptions,
......@@ -23,7 +25,6 @@ const propTypes = {
dashboard: PropTypes.object,
fields: PropTypes.array.isRequired,
isEditing: PropTypes.bool.isRequired,
operator: PropTypes.object.isRequired,
parameter: PropTypes.object.isRequired,
parameters: PropTypes.array.isRequired,
parentFocusChanged: PropTypes.bool,
......@@ -69,11 +70,11 @@ export default class ParameterFieldWidget extends Component {
isEditing,
fields,
parentFocusChanged,
operator,
parameter,
parameters,
dashboard,
} = this.props;
const operator = deriveFieldOperatorFromParameter(parameter);
const { isFocused, widgetWidth } = this.state;
const { numFields = 1, multi = false, verboseName } = operator || {};
const savedValue = normalizeValue(this.props.value);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment