Merge pull request #8231 from metabase/fix-i18n-admin-settings

Fix admin settings when localized

frontend/src/metabase/admin/settings/containers/SettingsEditorApp.jsx

@@ -125,7 +125,7 @@ export default class SettingsEditorApp extends Component {
       return null;
     }
 
-    if (activeSection.name === "Email") {
+    if (activeSection.slug === "email") {
       return (
         <SettingsEmailForm
           ref="emailForm"
@@ -135,9 +135,9 @@ export default class SettingsEditorApp extends Component {
           clearEmailSettings={this.props.clearEmailSettings}
         />
       );
-    } else if (activeSection.name === "Setup") {
+    } else if (activeSection.slug === "setup") {
       return <SettingsSetupList ref="settingsForm" />;
-    } else if (activeSection.name === "Slack") {
+    } else if (activeSection.slug === "slack") {
       return (
         <SettingsSlackForm
           ref="slackForm"
@@ -145,7 +145,7 @@ export default class SettingsEditorApp extends Component {
           updateSlackSettings={this.props.updateSlackSettings}
         />
       );
-    } else if (activeSection.name === "Updates") {
+    } else if (activeSection.slug === "updates") {
       return (
         <SettingsUpdatesForm
           settings={this.props.settings}
@@ -153,7 +153,7 @@ export default class SettingsEditorApp extends Component {
           updateSetting={this.updateSetting}
         />
       );
-    } else if (activeSection.name === "Authentication") {
+    } else if (activeSection.slug === "authentication") {
       // HACK - the presence of this param is a way for us to tell if
       // a user is looking at a sub section of the autentication section
       // since allowing for multi page settings more broadly would require
@@ -225,13 +225,13 @@ export default class SettingsEditorApp extends Component {
         "justify-between",
         "no-decoration",
         {
-          selected: activeSection && section.name === activeSection.name, // this.state.currentSection === idx
+          selected: activeSection && section.slug === activeSection.slug, // this.state.currentSection === idx
         },
       );
 
       // if this is the Updates section && there is a new version then lets add a little indicator
       let newVersionIndicator;
-      if (section.name === "Updates" && newVersionAvailable) {
+      if (section.slug === "updates" && newVersionAvailable) {
         newVersionIndicator = (
           <span
             style={{ padding: "4px 8px 4px 8px" }}
@@ -243,7 +243,7 @@ export default class SettingsEditorApp extends Component {
       }
 
       return (
-        <li key={section.name}>
+        <li key={section.slug}>
           <Link to={"/admin/settings/" + section.slug} className={classes}>
             <span>{section.name}</span>
             {newVersionIndicator}