Fix flaky dashcards test (#48676)

* Revert "fix flakiness during resize (#48556)"

This reverts commit 03b6584b.

* Move .should call up to fix flaky test

* Use consistent naming

e2e/support/helpers/e2e-ui-elements-overflow-helpers.js

@@ -34,18 +34,14 @@ export const assertDescendantNotOverflowsContainer = (
     return;
   }
 
-  cy.wrap(descendantRect).should($descendantRect => {
-    expect($descendantRect.bottom, `${message} bottom`).to.be.lte(
-      containerRect.bottom,
-    );
-    expect($descendantRect.top, `${message} top`).to.be.gte(containerRect.top);
-    expect($descendantRect.left, `${message} left`).to.be.gte(
-      containerRect.left,
-    );
-    expect($descendantRect.right, `${message} right`).to.be.lte(
-      containerRect.right,
-    );
-  });
+  expect(descendantRect.bottom, `${message} bottom`).to.be.lte(
+    containerRect.bottom,
+  );
+  expect(descendantRect.top, `${message} top`).to.be.gte(containerRect.top);
+  expect(descendantRect.left, `${message} left`).to.be.gte(containerRect.left);
+  expect(descendantRect.right, `${message} right`).to.be.lte(
+    containerRect.right,
+  );
 };
 
 export const assertIsEllipsified = element => {

e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js

@@ -1095,15 +1095,17 @@ describe("issue 31628", () => {
   };
 
   const assertDescendantsNotOverflowDashcards = descendantsSelector => {
-    cy.findAllByTestId("dashcard").each((dashcard, dashcardIndex) => {
-      const descendants = dashcard.find(descendantsSelector);
-
-      descendants.each((_descendantIndex, descendant) => {
-        assertDescendantNotOverflowsContainer(
-          descendant,
-          dashcard[0],
-          `dashcard[${dashcardIndex}] [data-testid="${descendant.dataset.testid}"]`,
-        );
+    cy.findAllByTestId("dashcard").should(dashcards => {
+      dashcards.each((dashcardIndex, dashcard) => {
+        const descendants = dashcard.querySelectorAll(descendantsSelector);
+
+        descendants.forEach(descendant => {
+          assertDescendantNotOverflowsContainer(
+            descendant,
+            dashcard,
+            `dashcard[${dashcardIndex}] [data-testid="${descendant.dataset.testid}"]`,
+          );
+        });
       });
     });
   };