Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

467eca89

Unverified Commit 467eca89 authored 3 years ago by Alexander Lesnenko Committed by GitHub 3 years ago

Downloads
- Patches
- Plain Diff

show meaningful error for waterfall chart of multiple series questions (#17992)

* show meaningful error for waterfall chart of multiple series questions

* increase readability

parent 74018323

Branches

Tags

No related merge requests found

Changes 8

Hide whitespace changes

Inline Side-by-side

Showing

frontend/src/metabase/visualizations/components/LineAreaBarChart.jsx 4 additions, 0 deletions

...c/metabase/visualizations/components/LineAreaBarChart.jsx
frontend/src/metabase/visualizations/components/settings/ChartSettingFieldPicker.jsx 1 addition, 0 deletions

...lizations/components/settings/ChartSettingFieldPicker.jsx
frontend/src/metabase/visualizations/index.js 5 additions, 0 deletions

frontend/src/metabase/visualizations/index.js
frontend/src/metabase/visualizations/lib/RowRenderer.js 0 additions, 4 deletions

frontend/src/metabase/visualizations/lib/RowRenderer.js
frontend/src/metabase/visualizations/lib/settings/graph.js 13 additions, 5 deletions

frontend/src/metabase/visualizations/lib/settings/graph.js
frontend/src/metabase/visualizations/visualizations/RowChart.jsx 1 addition, 0 deletions

...d/src/metabase/visualizations/visualizations/RowChart.jsx
frontend/src/metabase/visualizations/visualizations/WaterfallChart.jsx 3 additions, 1 deletion

...metabase/visualizations/visualizations/WaterfallChart.jsx
frontend/test/metabase/scenarios/visualizations/waterfall.cy.spec.js 8 additions, 4 deletions

...st/metabase/scenarios/visualizations/waterfall.cy.spec.js

with 35 additions and 14 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment