Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
4700c033
Commit
4700c033
authored
9 years ago
by
Kyle Doherty
Browse files
Options
Downloads
Patches
Plain Diff
fix issue with absolutely positioned empty state messaging
parent
c4bc9011
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
frontend/src/dashboard/components/Dashboard.jsx
+2
-2
2 additions, 2 deletions
frontend/src/dashboard/components/Dashboard.jsx
frontend/src/dashboard/components/DashboardHeader.jsx
+1
-1
1 addition, 1 deletion
frontend/src/dashboard/components/DashboardHeader.jsx
with
3 additions
and
3 deletions
frontend/src/dashboard/components/Dashboard.jsx
+
2
−
2
View file @
4700c033
...
...
@@ -47,12 +47,12 @@ export default class Dashboard extends Component {
<
LoadingAndErrorWrapper
className
=
"Dashboard full-height"
loading
=
{
!
dashboard
}
error
=
{
error
}
>
{
()
=>
<
div
className
=
"full"
>
<
header
className
=
"bg-white border-bottom"
>
<
header
className
=
"bg-white border-bottom
relative z2
"
>
<
DashboardHeader
{
...
this
.
props
}
/>
</
header
>
<
div
className
=
"Dash-wrapper wrapper"
>
{
dashboard
.
ordered_cards
.
length
===
0
?
<
div
className
=
"absolute top bottom left right flex flex-column layout-centered"
>
<
div
className
=
"absolute
z1
top bottom left right flex flex-column layout-centered"
>
<
span
className
=
"QuestionCircle"
>
?
</
span
>
<
div
className
=
"text-normal mt3 mb1"
>
This dashboard is looking empty.
</
div
>
<
div
className
=
"text-normal text-grey-2"
>
Add a question to start making it useful!
</
div
>
...
...
This diff is collapsed.
Click to expand it.
frontend/src/dashboard/components/DashboardHeader.jsx
+
1
−
1
View file @
4700c033
...
...
@@ -150,7 +150,7 @@ export default class DashboardHeader extends Component {
ref
=
"addQuestionModal"
triggerElement
=
{
<
a
data-metabase-event
=
"Dashboard;Add Card Modal"
title
=
"Add a question to this dashboard"
>
<
Icon
className
=
{
cx
(
"
text-brand-hover
"
,
{
"
Icon--pulse
"
:
isEmpty
})
}
name
=
"add"
width
=
"16px"
height
=
"16px"
/>
<
Icon
className
=
{
cx
(
"
text-brand-hover
cursor-pointer
"
,
{
"
Icon--pulse
"
:
isEmpty
})
}
name
=
"add"
width
=
"16px"
height
=
"16px"
/>
</
a
>
}
>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment