-
- Downloads
Restore table visibility (#15916)
* Move unhidden table sync off-thread
* Test bulk hide/unhide syncing
* Check can connect to db and serialize syncs
rather than allowing us to create threads willy nilly, serialize them
and reuse them in a fixed thread pool with a single thread. This helps
if someone "multiple clicks" and launches a few table syncs. It's not
appropriate to use the existing deduplicating stuff in the sync which
prevents later tasks from happening while the current sync step
happens since we want to sync with the most recent changes. So just
serialize them to go one at a time rather than off to the races.
* Clean up ns, make private, and type hints
* Block waiting on table sync to finish
* Use driver.util can connect helper
uses the timeout of 5seconds and catches errors
* disable ToggleHiddenButton during request
Co-authored-by:
Dalton Johnson <daltojohnso@users.noreply.github.com>
Showing
- frontend/src/metabase/admin/datamodel/components/database/MetadataTableList.jsx 26 additions, 6 deletions...admin/datamodel/components/database/MetadataTableList.jsx
- frontend/src/metabase/css/core/cursor.css 4 additions, 0 deletionsfrontend/src/metabase/css/core/cursor.css
- src/metabase/api/table.clj 63 additions, 30 deletionssrc/metabase/api/table.clj
- test/metabase/api/table_test.clj 48 additions, 23 deletionstest/metabase/api/table_test.clj
- test/metabase/sync/analyze_test.clj 13 additions, 6 deletionstest/metabase/sync/analyze_test.clj
Loading
Please register or sign in to comment