Ensure that features in stats ping can only be enabled if available (#48493)

src/metabase/analytics/stats.clj

@@ -641,10 +641,10 @@
     :available true
     :enabled   (slack/slack-configured?)}
    {:name      :sso-google
-    :available (premium-features/enable-sso-google?)
+    :available true
     :enabled   (google/google-auth-configured)}
    {:name      :sso-ldap
-    :available (premium-features/enable-sso-ldap?)
+    :available true
     :enabled   (public-settings/ldap-enabled?)}
    {:name      :sample-data
     :available true
@@ -677,13 +677,13 @@
     :enabled   (t2/exists? :model/Database :uploads_enabled true)}
    {:name      :mb-analytics
     :available (premium-features/enable-audit-app?)
-    :enabled   true}
+    :enabled   (premium-features/enable-audit-app?)}
    {:name      :advanced-permissions
     :available (premium-features/enable-advanced-permissions?)
-    :enabled   true}
+    :enabled   (premium-features/enable-advanced-permissions?)}
    {:name      :serialization
     :available (premium-features/enable-serialization?)
-    :enabled   true}
+    :enabled   (premium-features/enable-serialization?)}
    {:name      :official-collections
     :available (premium-features/enable-official-collections?)
     :enabled   (t2/exists? :model/Collection :authority_level "official")}
@@ -722,10 +722,12 @@
   []
   (let [features (concat (snowplow-features-data) (ee-snowplow-features-data))]
     (mapv
-     ;; Convert keys and feature names to strings to match expected Snowplow scheml
+     ;; Convert keys and feature names to strings to match expected Snowplow schema
      (fn [feature]
        (-> (update feature :name name)
            (update :name u/->snake_case_en)
+           ;; Ensure that unavailable features are not reported as enabled
+           (update :enabled (fn [enabled?] (if-not (:available feature) false enabled?)))
            (walk/stringify-keys)))
      features)))
 

test/metabase/analytics/stats_test.clj

@@ -423,6 +423,21 @@
                     config/current-minor-version (constantly nil)]
         (is false? (@#'stats/csv-upload-available?))))))
 
+(deftest no-features-enabled-but-not-available-test
+  (testing "Ensure that a feature cannot be reported as enabled if it is not also available"
+    ;; Clear premium features so (most of) the features are considered unavailable
+    (mt/with-premium-features #{}
+      ;; Temporarily create an official collection so that the stats code detects at least one feature as "enabled"
+      (mt/with-temp [:model/Collection {} {:name "Temp Official Collection" :authority_level "official"}]
+        (let [features (@#'stats/snowplow-features)
+              enabled-not-available (filter
+                                     (fn [feature]
+                                       (and (get feature "enabled")
+                                            (not (get feature "available"))))
+                                     features)]
+          ;; No features should be considered enabled which are not also considered available
+          (is (= [] enabled-not-available)))))))
+
 (def ^:private excluded-features
   "Set of features intentionally excluded from the daily stats ping. If you add a new feature, either add it to the stats ping
   or to this set, so that [[every-feature-is-accounted-for-test]] passes."