Skip to content
Snippets Groups Projects
Unverified Commit 4cf62603 authored by Nemanja Glumac's avatar Nemanja Glumac Committed by GitHub
Browse files

[E2E] Fix `filters` flakes (#23440)

* Fix flake in repro for 16386

* Fix flake in repro for 22730
parent 288e52f6
No related branches found
No related tags found
No related merge requests found
...@@ -932,8 +932,9 @@ describe("scenarios > question > filter", () => { ...@@ -932,8 +932,9 @@ describe("scenarios > question > filter", () => {
beforeEach(setupBooleanQuery); beforeEach(setupBooleanQuery);
it("from the column popover (metabase#16386-1)", () => { it("from the column popover (metabase#16386-1)", () => {
cy.get(".cellData") cy.findAllByTestId("header-cell")
.contains("boolean") .contains("boolean")
.should("be.visible")
.click(); .click();
popover() popover()
......
...@@ -14,22 +14,31 @@ describe("issue 22730", () => { ...@@ -14,22 +14,31 @@ describe("issue 22730", () => {
}, },
{ visitQuestion: true }, { visitQuestion: true },
); );
cy.intercept("POST", "/api/dataset").as("dataset"); cy.intercept("POST", "/api/dataset").as("dataset");
}); });
it("allows filtering by time column (metabase#22730)", () => { it("allows filtering by time column (metabase#22730)", () => {
cy.findByText("Explore results").click(); cy.findByText("Explore results").click();
cy.findByText("time").click(); cy.wait("@dataset");
cy.findAllByTestId("header-cell")
.contains("time")
.should("be.visible")
.click();
popover().within(() => { popover().within(() => {
cy.findByText("Filter by this column").click(); cy.findByText("Filter by this column").click();
cy.findByTestId("hours-input") cy.findByTestId("hours-input")
.clear() .clear()
.type("14"); .type("14")
.blur();
cy.findByTestId("minutes-input") cy.findByTestId("minutes-input")
.clear() .clear()
.type("03"); .type("03")
.blur();
cy.button("Add filter").click(); cy.button("Add filter").click();
}); });
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment