Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

4d31c458

Unverified Commit 4d31c458 authored 2 years ago by Cam Saul Committed by GitHub 2 years ago

Downloads
- Patches
- Plain Diff

`mbql.u/add-temporal-unit` should ignore invalid units (#22156)

* mbql.u/add-temporal-unit should ignore invalid units rather than erroring

* Test fixes

parent b07bd109

Branches

Tags

No related merge requests found

Changes 6

Hide whitespace changes

Inline Side-by-side

Showing

shared/src/metabase/mbql/normalize.cljc 2 additions, 2 deletions

shared/src/metabase/mbql/normalize.cljc
shared/src/metabase/mbql/schema.cljc 17 additions, 10 deletions

shared/src/metabase/mbql/schema.cljc
shared/src/metabase/mbql/util.cljc 11 additions, 2 deletions

shared/src/metabase/mbql/util.cljc
shared/test/metabase/mbql/normalize_test.cljc 21 additions, 13 deletions

shared/test/metabase/mbql/normalize_test.cljc
shared/test/metabase/mbql/schema_test.cljc 22 additions, 21 deletions

shared/test/metabase/mbql/schema_test.cljc
shared/test/metabase/mbql/util_test.cljc 10 additions, 0 deletions

shared/test/metabase/mbql/util_test.cljc

with 83 additions and 48 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment