Add error handling, (test) api endpoint

src/metabase/api/x_ray.clj

 (ns metabase.api.x-ray
   (:require [compojure.core :refer [GET]]
             [metabase.api.common :as api]
-            [metabase.feature-extraction.core :as fe]
+            [metabase.feature-extraction
+             [async :as async]
+             [core :as fe]]
             [metabase.models
              [card :refer [Card]]
+             [computation-job :refer [ComputationJob]]
              [field :refer [Field]]
              [metric :refer [Metric]]
              [segment :refer [Segment]]
@@ -50,6 +53,25 @@
                                                  max_computation_cost)})
        fe/x-ray))
 
+(api/defendpoint GET "/async/table/:id"
+  "Get x-ray for a `Tield` with ID."
+  [id max_query_cost max_computation_cost]
+  {max_query_cost       MaxQueryCost
+   max_computation_cost MaxComputationCost}
+  (let [table (api/read-check Table id)]
+    {:job-id (async/compute
+              #(->> table
+                    (fe/extract-features {:max-cost (max-cost max_query_cost
+                                                              max_computation_cost)})
+                    fe/x-ray))}))
+
+(api/defendpoint GET "/async/:id"
+  "Get x-ray for a `Tield` with ID."
+  [id]
+  (->> id
+       ComputationJob
+       async/result))
+
 (api/defendpoint GET "/segment/:id"
   "Get x-ray for a `Segment` with ID."
   [id max_query_cost max_computation_cost]
@@ -179,8 +201,8 @@
   "Get a list of model pairs that can be compared."
   []
   [["field" "field"]
-   ["segment" "segment"
-    "table" "table"
-    "segment" "table"]])
+   ["segment" "segment"]
+   ["table" "table"]
+   ["segment" "table"]])
 
 (api/define-routes)

src/metabase/feature_extraction/async.clj

@@ -5,12 +5,12 @@
              [computation-job-result :refer [ComputationJobResult]]]
             [toucan.db :as db]))
 
-(def ^:private running-jobs (atom {}))
+(defonce ^:private running-jobs (atom {}))
 
 (defn done?
   "Is the computation job done?"
   [{:keys [status]}]
-  (= :done status))
+  (#{:done :error} status))
 
 (defn running?
   "Is the computation job still running?"
@@ -27,6 +27,16 @@
     (db/update! ComputationJob id :status :done))
   (swap! running-jobs dissoc id))
 
+(defn- save-error
+  [{:keys [id]} error]
+  (db/transaction
+    (db/insert! ComputationJobResult
+      :job_id     id
+      :permanence :temporary
+      :payload    (Throwable->map error))
+    (db/update! ComputationJob id :status :error))
+  (swap! running-jobs dissoc id))
+
 (defn cancel
   "Cancel computation job (if still running)."
   [{:keys [id] :as job}]
@@ -44,7 +54,11 @@
                         :status     :running
                         :type       :simple-job)
         id  (:id job)]
-    (swap! running-jobs assoc id (future (save-result job (f))))
+    (swap! running-jobs assoc id (future
+                                   (try
+                                     (save-result job (f))
+                                     (catch Exception e
+                                       (save-error job e)))))
     id))
 
 (defn result
@@ -52,7 +66,7 @@
   [job]
   (if (done? job)
     (if-let [result (db/select-one ComputationJobResult :job_id (:id job))]
-      {:status :done
+      {:status (:status job)
        :result (:payload result)}
       {:status :result-not-available})
     {:status (:status job)}))

src/metabase/models/computation_job_result.clj

@@ -9,5 +9,5 @@
   models/IModel
   (merge models/IModelDefaults
          {:types          (constantly {:permanence :keyword
-                                       :payload    :edn})
+                                       :payload    :json})
           :properties     (constantly {:timestamped? true})}))

src/metabase/models/interface.clj

@@ -37,10 +37,6 @@
   :in  identity
   :out u/jdbc-clob->str)
 
-(models/add-type! :edn
-  :in  pr-str
-  :out (comp edn/read-string u/jdbc-clob->str))
-
 (def ^:private encrypted-json-in  (comp encryption/maybe-encrypt json-in))
 (def ^:private encrypted-json-out (comp json-out encryption/maybe-decrypt))