Merge pull request #4908 from swisscom-bigdata/topN-limit-decrease

decreased the default limit of topN results to 1000

src/metabase/driver/druid/query_processor.clj

@@ -77,7 +77,7 @@
      ::total              (merge defaults {:queryType :timeseries})
      ::grouped-timeseries (merge defaults {:queryType :timeseries})
      ::topN               (merge defaults {:queryType :topN
-                                           :threshold i/absolute-max-results})
+                                           :threshold i/druid-topN-max-results})
      ::groupBy            (merge defaults {:queryType :groupBy})}))
 
 

src/metabase/query_processor/interface.clj

@@ -18,6 +18,13 @@
    https://support.office.com/en-nz/article/Excel-specifications-and-limits-1672b34d-7043-467e-8e27-269d656771c3"
   1048576)
 
+(def ^:const druid-topN-max-results
+  "Maximum number of rows the topN query in Druid should return. Huge values cause significant issues with the engine.
+
+   Coming from the default value hardcoded in the Druid engine itself
+   http://druid.io/docs/latest/querying/topnquery.html"
+  1000)
+
 
 ;;; # ------------------------------------------------------------ DYNAMIC VARS ------------------------------------------------------------