Show not found view when opening archived model (#28443)

* Add `isArchived` method to `Question` class

* Show nice not found view when opening archived model

frontend/src/metabase-lib/Question.ts

@@ -918,6 +918,10 @@ class QuestionInner {
     return table ? table.id : null;
   }
 
+  isArchived(): boolean {
+    return this._card && this._card.archived;
+  }
+
   getUrl({
     originalQuestion,
     clean = true,

frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.tsx

@@ -2,9 +2,11 @@ import React, { useEffect, useCallback, useMemo, useState } from "react";
 import _ from "underscore";
 import { connect } from "react-redux";
 import { replace } from "react-router-redux";
+import { useMount } from "react-use";
 import type { Location, LocationDescriptor } from "history";
 
-import { useMount } from "react-use";
+import { NotFound } from "metabase/containers/ErrorPages";
+
 import * as Urls from "metabase/lib/urls";
 
 import Actions from "metabase/entities/actions";
@@ -168,6 +170,10 @@ function ModelDetailPage({
     [model, onChangeCollection],
   );
 
+  if (model.isArchived()) {
+    return <NotFound />;
+  }
+
   return (
     <>
       <ModelDetailPageView

frontend/src/metabase/models/containers/ModelDetailPage/ModelDetailPage.unit.spec.tsx

@@ -864,5 +864,16 @@ describe("ModelDetailPage", () => {
         "true",
       );
     });
+
+    it("shows 404 when opening an archived model", async () => {
+      const model = getStructuredModel({ archived: true });
+      const modelName = model.displayName() as string;
+      await setup({ model });
+
+      expect(screen.queryByText(modelName)).not.toBeInTheDocument();
+      expect(
+        screen.getByText("The page you asked for couldn't be found."),
+      ).toBeInTheDocument();
+    });
   });
 });