Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
4e984956
Unverified
Commit
4e984956
authored
1 year ago
by
Nemanja Glumac
Committed by
GitHub
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
[E2E] Fix 18630 repro flake (#31548) (#31554)
parent
b5107521
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
e2e/test/scenarios/joins/reproductions/18630-field-literals-in-joins.cy.spec.js
+11
-9
11 additions, 9 deletions
...ns/reproductions/18630-field-literals-in-joins.cy.spec.js
with
11 additions
and
9 deletions
e2e/test/scenarios/joins/reproductions/18630-field-literals-in-joins.cy.spec.js
+
11
−
9
View file @
4e984956
import
{
restore
}
from
"
e2e/support/helpers
"
;
import
{
restore
}
from
"
e2e/support/helpers
"
;
import
{
SAMPLE_DATABASE
}
from
"
e2e/support/cypress_sample_database
"
;
import
{
SAMPLE_DATABASE
}
from
"
e2e/support/cypress_sample_database
"
;
const
{
ORDERS
,
ORDERS_ID
,
PEOPLE
,
PEOPLE_ID
}
=
SAMPLE_DATABASE
;
const
{
ORDERS
,
ORDERS_ID
,
PEOPLE
,
PEOPLE_ID
}
=
SAMPLE_DATABASE
;
describe
(
"
issue 18630
"
,
()
=>
{
describe
(
"
issue 18630
"
,
()
=>
{
beforeEach
(()
=>
{
beforeEach
(()
=>
{
cy
.
intercept
(
"
POST
"
,
"
/api/dataset
"
).
as
(
"
dataset
"
);
restore
();
restore
();
cy
.
signInAsAdmin
();
cy
.
signInAsAdmin
();
});
});
...
@@ -48,17 +46,21 @@ describe("issue 18630", () => {
...
@@ -48,17 +46,21 @@ describe("issue 18630", () => {
alias
:
"
People
"
,
alias
:
"
People
"
,
},
},
],
],
limit
:
3
,
};
const
questionDetails
=
{
name
:
"
18630
"
,
query
:
QUERY_WITH_FIELD_CLAUSE
,
};
};
it
(
"
should normally open queries with field literals in joins (metabase#18630)
"
,
()
=>
{
it
(
"
should normally open queries with field literals in joins (metabase#18630)
"
,
()
=>
{
cy
.
createQuestion
(
cy
.
createQuestion
(
questionDetails
,
{
visitQuestion
:
true
});
{
query
:
QUERY_WITH_FIELD_CLAUSE
},
{
visitQuestion
:
true
},
);
// The query runs and we assert the page is not blank,
// The query runs and we assert the page is not blank,
// rather than an infinite loop and stack overflow.
// which was caused by an infinite loop and a stack overflow.
// 'test question' is the name of the question.
cy
.
findByDisplayValue
(
questionDetails
.
name
);
cy
.
findByText
(
"
test question
"
);
cy
.
get
(
"
.cellData
"
).
contains
(
"
29494 Anderson Drive
"
);
cy
.
findByText
(
"
Showing 3 rows
"
);
});
});
});
});
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment