-
- Downloads
migrate pie chart to echarts (#43555)
* echarts pie
* setup rendering pipeline for static pie chart (#43547)
* setup rendering pipeline for static pie chart
* remove more donut code from BE
* compute viz settings for static pie chart (#43548)
* compute viz settings for static pie chart
* create chartModel for pie chart (#43549)
* create chartModel for pie chart
* render static pie chart (#43550)
* render static pie chart
* render static pie chart legend (#43551)
* disable animation
* alter static-viz pie chart be tests to account for echarts-impl
The old implementation had a different implementation for legends, separate from the 'categorical/donut' js
render. Echarts nicely combines the legend into the pie render, so we don't need to worry about that stuff anymore.
Instead, I've written a simple set of assertions on the echarts pie implementation now.
* Get rid of this test that was attempting to use old code path
* echarts pie
* One last spot where we don't need old pie stuff anymore.
* add loki specs
* save snapshots
* fix small slices disappearing
* update snapshots
* add repro story for exteremely small slice
* add snapshot
* fix rounded total
* fix percent formatting in legend
* fix date dimension formatting
* fix binned and relative date dimension labels on legend
* add specs and snapshots for null and unaggregated dimensions
* hide overlaping labels on chart
* fix null dimension color
* show error when metric column has a negative value
* move legend to botom
* make dot margin smaller
* add columns to legend
* sort legend vertically
* dont use grid if only one row for legend
* never hide legend in static viz
* fix empty column culling
* show single legend item
* add long dimension name story
* fix long dimension name in legend
* right justify percentages in legend
* remove negative error and re-add stories
* handle negative values
* create chart definition for dynamic pie chart
* render chart with responsiveness
* add comment for borderWidth calculation
* center legend
* fix legend centering
* add story for missing currency formatting
* fix missing currency formatting
* fix graalvm crashing
* fix column settings computation
* add another currency formatting repro
* fix wrong order of col settings computations
* convert colors to hex
* fix colors missing from viz settings
* temp todo comment
* fix colors in dynamic viz
* update snapshots
* fix crashing due to invalid dimension/metric setting
* fix chart crashing for boolean dimension with labels on chart
* add repro
* fix regression in label formatting
* fix labels on small slices
* update specs
* emphasis state for slice hover
* recreate old label hiding logic
* include height measurement in getIsLabelVisible
* move d3 slices to chart model
* fix labels on static viz
* wip basic hover state and tooltip
* fix emphasis style getting stuck by memoizing everything
* update total display value
* fix stuck emphasis by setting notMerge to false for pie only
* handle other slice in tooltip
* fix bugs in total graphic
* use OTHER_SLICE_KEY const in static viz legend
* implement legend and connect to hover state
* implement click actions
* fix slice not clickable
* handle all zero slices
* add repro
* update specs
* update pie_chart.cy.spec.js
* update chart_drill.cy.spec.js
* add repro for single column legend
* use minimum 2 legend columns
* fix legend text overlap
* use more margin for single row legend
* update specs
* add repro for 28568
* add repro for 38424
* fix percent label not showing on large slices
* hide total text when chart is small
* replace comment about animations
* show warning for mixed positive and negative values
* delete old chart files
* fix type errors
* update d3 import
* update specs
* remove branch from uberjar.yml
* dont put single slice into other
* fix lint errors and pie render test
* update more d3 imports
* remove unused settings
* revert preview-card-width change
* remove unused import
* remove majorWidth option from formatting
* use debounceLeading refresh mode in ChartWithLegend
* remove TOTAL_GRAPHIC_OPTION constant
* delete unit test for pie chart
* fix failing test by doing set comparison instead
* fix typo in comment
* remove SUNBURST_SERIES_OPTION constant
* fix lint by removing unused eslint-disable
* move default color computation to getValue
* fix static pie test to show that we will always render the legend
* update pie border color for night mode and embedding
* fix styles for embedding case and add stories
* skip embedding stories
---------
Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
Showing
- .loki/reference/chrome_laptop_Visualizations_ChartSkeleton_Pie.png 0 additions, 0 deletions...erence/chrome_laptop_Visualizations_ChartSkeleton_Pie.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png 0 additions, 0 deletions...mbed_PublicOrEmbeddedDashboardView_Dark_Theme_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Default.png 0 additions, 0 deletions...mbeddedDashboardView_Dark_Theme_No_Background_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png 0 additions, 0 deletions...EmbeddedDashboardView_Dark_Theme_No_Background_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png 0 additions, 0 deletions...embed_PublicOrEmbeddedDashboardView_Dark_Theme_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png 0 additions, 0 deletions...bed_PublicOrEmbeddedDashboardView_Light_Theme_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Light_Theme_No_Background_Scroll.png 0 additions, 0 deletions...mbeddedDashboardView_Light_Theme_No_Background_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png 0 additions, 0 deletions...mbed_PublicOrEmbeddedDashboardView_Light_Theme_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Default.png 0 additions, 0 deletions...blicOrEmbeddedDashboardView_Transparent_Theme_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Default.png 0 additions, 0 deletions...DashboardView_Transparent_Theme_No_Background_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Transparent_Theme_No_Background_Scroll.png 0 additions, 0 deletions...dDashboardView_Transparent_Theme_No_Background_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png 0 additions, 0 deletions...ublicOrEmbeddedDashboardView_Transparent_Theme_Scroll.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png 0 additions, 0 deletions...embed_PublicOrEmbeddedQuestionView_Dark_Theme_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png 0 additions, 0 deletions...mbed_PublicOrEmbeddedQuestionView_Light_Theme_Default.png
- .loki/reference/chrome_laptop_embed_PublicOrEmbeddedQuestionView_Transparent_Theme_Default.png 0 additions, 0 deletions...ublicOrEmbeddedQuestionView_Transparent_Theme_Default.png
- .loki/reference/chrome_laptop_static_viz_CategoricalDonutChart_Default.png 0 additions, 0 deletions...hrome_laptop_static_viz_CategoricalDonutChart_Default.png
- .loki/reference/chrome_laptop_static_viz_ComboChart_Area_Over_Bar.png 0 additions, 0 deletions...nce/chrome_laptop_static_viz_ComboChart_Area_Over_Bar.png
- .loki/reference/chrome_laptop_static_viz_ComboChart_Area_Stack_All_Series_Without_Interpolation.png 0 additions, 0 deletions...omboChart_Area_Stack_All_Series_Without_Interpolation.png
- .loki/reference/chrome_laptop_static_viz_ComboChart_Area_Stack_Interpolate_Missing_Values.png 0 additions, 0 deletions..._viz_ComboChart_Area_Stack_Interpolate_Missing_Values.png
- .loki/reference/chrome_laptop_static_viz_ComboChart_Area_Stack_Linear_X_Axis.png 0 additions, 0 deletions...laptop_static_viz_ComboChart_Area_Stack_Linear_X_Axis.png
Loading
Please register or sign in to comment