Skip to content
Snippets Groups Projects
Unverified Commit 500d407c authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Fix Visualization component handling of mode prop (#25438)

* Fix Visualization component handling of mode prop

* Pass mode prop in and give it a gross name
parent 4e4a1243
No related branches found
No related tags found
No related merge requests found
......@@ -213,6 +213,18 @@ class Visualization extends React.PureComponent {
: question;
}
getMode(maybeModeOrQueryMode, question) {
if (maybeModeOrQueryMode instanceof Mode) {
return maybeModeOrQueryMode;
}
if (question && maybeModeOrQueryMode) {
return new Mode(question, maybeModeOrQueryMode);
}
return question?.mode();
}
getClickActions(clicked) {
if (!clicked) {
return [];
......@@ -222,9 +234,7 @@ class Visualization extends React.PureComponent {
const seriesIndex = clicked.seriesIndex || 0;
const card = this.state.series[seriesIndex].card;
const question = this._getQuestionForCardCached(metadata, card);
const mode = this.props.mode
? question && new Mode(question, this.props.mode)
: question && question.mode();
const mode = this.getMode(this.props.mode, question);
return mode
? mode.actionsForClick(
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment