Skip to content
Snippets Groups Projects
Commit 506d3b3d authored by Andres Gomez Urquiza's avatar Andres Gomez Urquiza
Browse files

empty card identification in pulse.render more robust

parent df701a3b
No related branches found
No related tags found
No related merge requests found
......@@ -38,7 +38,8 @@ export default class PulseEditChannels extends Component {
user: PropTypes.object.isRequired,
userList: PropTypes.array.isRequired,
setPulse: PropTypes.func.isRequired,
testPulse: PropTypes.func.isRequired
testPulse: PropTypes.func.isRequired,
cardPreviews: PropTypes.array
};
static defaultProps = {};
......@@ -135,7 +136,6 @@ export default class PulseEditChannels extends Component {
}
willPulseSkip() {
console.log(this);
let cards = _.pluck(this.props.pulse.cards, 'id');
let cardPreviews = this.props.cardPreviews;
let previews = _.map(cards, function (id) { return _.find(cardPreviews, function(card){ return (id == card.id);})});
......
......@@ -390,7 +390,11 @@
(cond
(or (= aggregation :rows)
(contains? #{:pin_map :state :country} (:display card))) nil
(zero? row-count) :empty
(or (zero? (-> card :rows count))
(= [[nil]]
(-> card :rows))
(= [[0]]
(-> card :rows))) :empty
(and (= col-count 1)
(= row-count 1)) :scalar
(and (= col-count 2)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment