Skip to content
Snippets Groups Projects
Unverified Commit 5116f76b authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Fix #33083 (part 2) (#33453)

* Fix #33083 (part 2)

* Equality nonsense

* Test fix

* Remove leftover test

* Cljs fix

* Appease Kondo

* Appease Kondo more

* PR feedback

* `index-of-matching-metadata`

* Update some other things to use `index-of-closest-matching-metadata`

* PR feedback

* Don't use metadata provider for ref <=> metadata comparisons

* mark-selected-columns doesn't need metadata provider

* Update some join stuff to match with metadata

* Update more stuff to use `closest-matching-metadata`

* Test fix :wrench:

* Test fix

* Take advantage of the QP now using MLv2 metadata providers to simplify test

* Well ok maybe we do need the 3-arity after all =(

* Test fix

* Remove stray NOCOMMIT

* Some cleanup and extra tests

* Hopefully the last few test fixes

* Ok NOW I think I fixed stuff.

* Add a test for binning display name (degrees)

* Fix indentation

* Give up on the Card nonsense for now

* Ok I give up

* Revert changes to testing
parent 167153ca
No related branches found
No related tags found
No related merge requests found
Showing
with 375 additions and 230 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment