Fix #33083 (part 2) (#33453)
* Fix #33083 (part 2) * Equality nonsense * Test fix * Remove leftover test * Cljs fix * Appease Kondo * Appease Kondo more * PR feedback * `index-of-matching-metadata` * Update some other things to use `index-of-closest-matching-metadata` * PR feedback * Don't use metadata provider for ref <=> metadata comparisons * mark-selected-columns doesn't need metadata provider * Update some join stuff to match with metadata * Update more stuff to use `closest-matching-metadata` * Test fix* Test fix * Take advantage of the QP now using MLv2 metadata providers to simplify test * Well ok maybe we do need the 3-arity after all =( * Test fix * Remove stray NOCOMMIT * Some cleanup and extra tests * Hopefully the last few test fixes * Ok NOW I think I fixed stuff. * Add a test for binning display name (degrees) * Fix indentation * Give up on the Card nonsense for now * Ok I give up * Revert changes to testing
Showing
- dev/src/dev/debug_qp.clj 20 additions, 18 deletionsdev/src/dev/debug_qp.clj
- e2e/test/scenarios/joins/reproductions/22859-multi-nested-joins-wrong-aliasing.cy.spec.js 1 addition, 0 deletions...ctions/22859-multi-nested-joins-wrong-aliasing.cy.spec.js
- src/metabase/api/dataset.clj 1 addition, 1 deletionsrc/metabase/api/dataset.clj
- src/metabase/lib/binning.cljc 9 additions, 9 deletionssrc/metabase/lib/binning.cljc
- src/metabase/lib/breakout.cljc 12 additions, 15 deletionssrc/metabase/lib/breakout.cljc
- src/metabase/lib/card.cljc 40 additions, 15 deletionssrc/metabase/lib/card.cljc
- src/metabase/lib/convert.cljc 24 additions, 14 deletionssrc/metabase/lib/convert.cljc
- src/metabase/lib/equality.cljc 81 additions, 20 deletionssrc/metabase/lib/equality.cljc
- src/metabase/lib/field.cljc 41 additions, 34 deletionssrc/metabase/lib/field.cljc
- src/metabase/lib/filter.cljc 3 additions, 6 deletionssrc/metabase/lib/filter.cljc
- src/metabase/lib/join.cljc 14 additions, 17 deletionssrc/metabase/lib/join.cljc
- src/metabase/lib/metadata.cljc 2 additions, 0 deletionssrc/metabase/lib/metadata.cljc
- src/metabase/lib/order_by.cljc 12 additions, 13 deletionssrc/metabase/lib/order_by.cljc
- src/metabase/lib/schema.cljc 6 additions, 2 deletionssrc/metabase/lib/schema.cljc
- src/metabase/lib/schema/binning.cljc 2 additions, 2 deletionssrc/metabase/lib/schema/binning.cljc
- src/metabase/lib/stage.cljc 7 additions, 4 deletionssrc/metabase/lib/stage.cljc
- src/metabase/query_processor/middleware/binning.clj 63 additions, 35 deletionssrc/metabase/query_processor/middleware/binning.clj
- src/metabase/query_processor/middleware/fetch_source_query.clj 5 additions, 2 deletions...etabase/query_processor/middleware/fetch_source_query.clj
- src/metabase/query_processor/store.clj 9 additions, 3 deletionssrc/metabase/query_processor/store.clj
- src/metabase/query_processor/util/add_alias_info.clj 23 additions, 20 deletionssrc/metabase/query_processor/util/add_alias_info.clj
Loading
Please register or sign in to comment