Add temporal unit to display name (#48946)
* Add temporal unit to display name * Remove temporal unit adjustments from FE * formatColumn to displayNameForColumn * Factor out getFriendlyName * Adjust BE tests * Add require * Adjust FE unit tests * Adjust temporal-unit-parameters.cy.spec.js * Adjust dashboard-reproductions.cy.spec * Convert formatColumn occurrence * Adjust legacy display name logic generation After `getFriendlyName` was removed from FE, capitalization of display name should happen here. Logic is similar, should be adjusted prior merging the PR. * Adjust embedding-linked-filters.cy.spec.js * Adjust joins-reproductions.cy.spec.js * Adjust metrics-editing.cy.spec.js * Adjust timelines-question.cy.spec.js * Adjust offset.cy.spec.ts * TMP Avoid duplication of temporal unit in display name in MLv2 code * Probably FE fix: add default temporal bucket only if not present * WIP Add ends-with-temporal-unit? function Current strategy is to add temporal units to display names if same is not already present * Adjust display-name-method :metadata/column Append TU to display name only if different to what's already present * Adjust FE: show temporal unit that's present on field instead of default on hover on QueryColumnPicker element * Return also temporal-unit from visible-columns * Enable tempora-unit to be returned from previous-stage-or-source-visible-columns * WIP Adjust multi breakout multi stage e2e multiple-column-breakouts.cy.spec * Adjust multiple-column-breakouts.cy.spec.ts * It was not a bug. * Revert changes in _BaseBucketPickerPopover * Restore temporal-unit for next stages removal in stage.cljc * Add inherent-temporal-unit * Adjust display name temporal bucket logic * Rename to inherited-temporal-unit * Shutdown too broad display name capitalization * Eastwood * Adjust pivot-rows-order-test * Adjust pivot-non-numeric-values-in-aggregations * Adjust inherent to inherited * Rename to inherited * Add inherent-temporal-unit only to returned-columns * Update e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Update consistent-date-formatting-test * Update dashboard/x-rays.cy.spec.js * Update waterfall.cy.spec.js * Return month default for default inherited-temporal-unit * Update reproductions-3.cy.spec.js * Update downloads/downloads.cy.spec.js * Update legend.cy.spec.js * Update pie_chart.cy.spec.js * Update click-behavior.cy.spec.js * Update embedding-linked-filters.cy.spec.js * Return QueryColumnPicker's condition to original state * Remove reundant export * Update e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts * Comment * Update nested.cy.spec.js * Update e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js * Adjust to TS types * Adjust for cljfmt * Capitalize * Add propagation tests * Add inherited-temporal-unit propagation for expressions * Add default inherited-temporal-unit test cases * Add qp temporal-bucket-test ns * Simplify default unit logic * Comment * Use NULL_DISPLAY_VALUE * Comment * Comment * Comment * Comment * Comment * Comment * Remove redundant code (for now) * Update comments * Comment * Restore way too daring simplification * cljfmt * Adjust capitalize * Update comment * Update test * Address remarks in tests * Update test * Address remarks * typo
Showing
- e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js
- e2e/test/scenarios/dashboard-filters/temporal-unit-parameters.cy.spec.js 5 additions, 3 deletions...ios/dashboard-filters/temporal-unit-parameters.cy.spec.js
- e2e/test/scenarios/dashboard/dashboard-reproductions.cy.spec.js 7 additions, 1 deletion...st/scenarios/dashboard/dashboard-reproductions.cy.spec.js
- e2e/test/scenarios/dashboard/x-rays.cy.spec.js 2 additions, 2 deletionse2e/test/scenarios/dashboard/x-rays.cy.spec.js
- e2e/test/scenarios/embedding/embedding-linked-filters.cy.spec.js 8 additions, 8 deletions...t/scenarios/embedding/embedding-linked-filters.cy.spec.js
- e2e/test/scenarios/joins/joins-reproductions.cy.spec.js 5 additions, 5 deletionse2e/test/scenarios/joins/joins-reproductions.cy.spec.js
- e2e/test/scenarios/metrics/metrics-editing.cy.spec.js 12 additions, 3 deletionse2e/test/scenarios/metrics/metrics-editing.cy.spec.js
- e2e/test/scenarios/organization/timelines-question.cy.spec.js 2 additions, 2 deletions...test/scenarios/organization/timelines-question.cy.spec.js
- e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js 4 additions, 4 deletions...enarios/question-reproductions/reproductions-3.cy.spec.js
- e2e/test/scenarios/question/multiple-column-breakouts.cy.spec.ts 67 additions, 47 deletions...t/scenarios/question/multiple-column-breakouts.cy.spec.ts
- e2e/test/scenarios/question/nested.cy.spec.js 6 additions, 8 deletionse2e/test/scenarios/question/nested.cy.spec.js
- e2e/test/scenarios/question/offset.cy.spec.ts 4 additions, 4 deletionse2e/test/scenarios/question/offset.cy.spec.ts
- e2e/test/scenarios/sharing/downloads/downloads.cy.spec.js 2 additions, 2 deletionse2e/test/scenarios/sharing/downloads/downloads.cy.spec.js
- e2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js 1 addition, 1 deletione2e/test/scenarios/sharing/sharing-reproductions.cy.spec.js
- e2e/test/scenarios/visualizations-charts/legend.cy.spec.js 7 additions, 7 deletionse2e/test/scenarios/visualizations-charts/legend.cy.spec.js
- e2e/test/scenarios/visualizations-charts/pie_chart.cy.spec.js 1 addition, 1 deletion...test/scenarios/visualizations-charts/pie_chart.cy.spec.js
- e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.js 2 additions, 2 deletions...test/scenarios/visualizations-charts/waterfall.cy.spec.js
- enterprise/frontend/src/metabase-enterprise/audit_app/components/AuditTableVisualization/AuditTableVisualization.jsx 2 additions, 2 deletions...nents/AuditTableVisualization/AuditTableVisualization.jsx
- frontend/src/metabase/lib/data_grid.js 2 additions, 2 deletionsfrontend/src/metabase/lib/data_grid.js
- frontend/src/metabase/lib/formatting/column.ts 7 additions, 16 deletionsfrontend/src/metabase/lib/formatting/column.ts
Loading
Please register or sign in to comment