Skip to content
Snippets Groups Projects
Unverified Commit 528b9c59 authored by Chris Truter's avatar Chris Truter Committed by GitHub
Browse files

Improve safety of lazily initialized settings (#37849)

- Introduce an "init" hook for application settings.
- Add guards against introducing race conditions again in other ways.
- Fix the usage of hygienic scope macros with read only settings.
- Lots of misc improvements to settings API and implementation.

This init hooks better ergonomics, and protects against race conditions. 
The previous pattern of calling setters inside getters almost caused a P0. 

See https://github.com/metabase/metabase/issues/37801.
parent 2cd8c5fa
Branches
Tags
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment