Merge pull request #2382 from metabase/dont-always-cast-datetimes

Skip casting a column if its unit is `:default` in the query

src/metabase/driver/bigquery.clj

@@ -255,7 +255,7 @@
 (defn- date [unit expr]
   {:pre [expr]}
   (case unit
-    :default         (kx/->timestamp expr)
+    :default         expr
     :minute          (trunc-with-format "%Y-%m-%d %H:%M:00" expr)
     :minute-of-hour  (kx/minute expr)
     :hour            (trunc-with-format "%Y-%m-%d %H:00:00" expr)

src/metabase/driver/h2.clj

@@ -141,7 +141,7 @@
 
 (defn- date [_ unit expr]
   (case unit
-    :default         (kx/->timestamp expr)
+    :default         expr
     :minute          (trunc-with-format "yyyyMMddHHmm" expr)
     :minute-of-hour  (kx/minute expr)
     :hour            (trunc-with-format "yyyyMMddHH" expr)

src/metabase/driver/mysql.clj

@@ -83,7 +83,7 @@
 
 (defn- date [_ unit expr]
   (case unit
-    :default         (k/sqlfn :TIMESTAMP expr)
+    :default         expr
     :minute          (trunc-with-format "%Y-%m-%d %H:%i" expr)
     :minute-of-hour  (kx/minute expr)
     :hour            (trunc-with-format "%Y-%m-%d %H" expr)

src/metabase/driver/postgres.clj

@@ -118,7 +118,7 @@
 
 (defn- date [_ unit expr]
   (case unit
-    :default         (kx/->timestamp expr)
+    :default         expr
     :minute          (date-trunc :minute expr)
     :minute-of-hour  (extract-integer :minute expr)
     :hour            (date-trunc :hour expr)

src/metabase/driver/sqlite.clj

@@ -43,7 +43,7 @@
             (kx/literal (u/date->iso-8601 expr))
             expr)]
     (case unit
-      :default         (->datetime v)
+      :default         v
       :second          (->datetime (strftime "%Y-%m-%d %H:%M:%S" v))
       :minute          (->datetime (strftime "%Y-%m-%d %H:%M" v))
       :minute-of-hour  (kx/->integer (strftime "%M" v))

src/metabase/driver/sqlserver.clj

@@ -80,7 +80,7 @@
   "See also the [jTDS SQL <-> Java types table](http://jtds.sourceforge.net/typemap.html)"
   [unit expr]
   (case unit
-    :default         (kx/->datetime expr)
+    :default         expr
     :minute          (kx/cast :SMALLDATETIME expr)
     :minute-of-hour  (date-part :minute expr)
     :hour            (kx/->datetime (kx/format "yyyy-MM-dd HH:00:00" expr))