Skip to content
Snippets Groups Projects
Unverified Commit 54c4fa9f authored by Nemanja Glumac's avatar Nemanja Glumac Committed by GitHub
Browse files

Repro #20519: Summarizing with implicit join does not allow subsequent joins...

Repro #20519: Summarizing with implicit join does not allow subsequent joins and nested query (#20521)

* Add repro for #20519

* Update frontend/test/metabase/scenarios/joins/reproductions/20519-cannot-join-on-aggregation-with-implicit-joins-and-nested-query.cy.spec.js

Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>

* Update frontend/test/metabase/scenarios/joins/reproductions/20519-cannot-join-on-aggregation-with-implicit-joins-and-nested-query.cy.spec.js

Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>

Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>
parent 6e17955c
No related branches found
No related tags found
No related merge requests found
import {
restore,
enterCustomColumnDetails,
visualize,
} from "__support__/e2e/cypress";
import { SAMPLE_DATABASE } from "__support__/e2e/cypress_sample_database";
const { ORDERS, ORDERS_ID, PRODUCTS, PRODUCTS_ID } = SAMPLE_DATABASE;
const questionDetails = {
name: "20519",
query: {
"source-query": {
"source-table": ORDERS_ID,
aggregation: [["count"]],
breakout: [
["field", PRODUCTS.CATEGORY, { "source-field": ORDERS.PRODUCT_ID }],
],
},
joins: [
{
fields: "all",
"source-table": PRODUCTS_ID,
condition: [
"=",
["field", "CATEGORY", { "base-type": "type/Text" }],
["field", PRODUCTS.CATEGORY, { "join-alias": "Products" }],
],
alias: "Products",
},
],
limit: 2,
},
};
describe.skip("issue 20519", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
cy.createQuestion(questionDetails, { visitQuestion: true });
switchToNotebookView();
});
// Tightly related issue: metabase#17767
it("should allow subsequent joins and nested query after summarizing on the implicit joins (metabase#20519)", () => {
cy.icon("add_data")
.last()
.click();
enterCustomColumnDetails({
formula: "1 + 1",
name: "Two",
});
cy.button("Done").click();
visualize(response => {
expect(response.body.error).not.to.exist;
});
cy.contains("Doohickey");
cy.contains("Two");
});
});
function switchToNotebookView() {
cy.intercept("GET", "/api/database/1/schema/PUBLIC").as("publicSchema");
cy.icon("notebook").click();
cy.wait("@publicSchema");
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment